Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Color module is going to be deprecated in 9.4 and removed in 10 #3270936: Deprecate Color module
Proposed resolution
Remove Color module from the Standard profile.
Remaining tasks
Patch
Review
Commit
User interface changes
no, for new installations and has no effect on existing ones
API changes
no
Data model changes
no
Release notes snippet
Standard profile will no longer enable the color module when installed.
Comment | File | Size | Author |
---|---|---|---|
#34 | 3270941-34.patch | 2.57 KB | heddn |
Comments
Comment #2
quietone CreditAttribution: quietone at PreviousNext commentedRemove release not snippet - it was for RDF.
Comment #3
longwaveNo patch to review yet!
Comment #4
quietone CreditAttribution: quietone at PreviousNext commentedSorry about that. I was making a couple of issue about the same time.
Let's start.
Comment #6
quietone CreditAttribution: quietone at PreviousNext commentedChanges for the two failing tests to remove color.
Comment #7
bbralaThis probably needs a reroll after #3270897: Handle migration tests for removing Color is committed.
Comment #8
yogeshmpawarPicking it now.
Comment #9
yogeshmpawarRerolled the patch against 9.4.x branch & added a reroll diff.
Comment #10
bbralaThese changes seem out of scope. These look like re-orders.
I think the only thing that needs to change is removing is from the
standard.info.yml
andPageCacheTagsIntegrationTest
.Comment #11
bbralaThis also needs a change record i think. But will ask around to verify.
Comment #12
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedMade changes as per comment #10.
Comment #13
bbralaChange notice added.
Comment #14
bbralaWhy id BigPipe suddenly appearing here? This feels like out of scope as mentioned in #10.
Comment #15
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedAddressed comment #14.
Comment #18
bbralaI think I was very wrong about my comments regarding the unrelated changes. Sorry about that, think my mind was in the mindset of removing this module from core, which is NOT what this issue is about. Sorry about that.
Seems like the patch in #9 is correct. But I don't trust myself anymore today :)
Comment #19
bbralaComment #20
yogeshmpawarThanks @bbrala. I am removing other patches after #9
Comment #21
xjmIs the addition of BigPipe here intentional? Edit: I see this was asked before, but not actually answered. Can we explain why BigPipe needs to be added?
Comment #22
quietone CreditAttribution: quietone at PreviousNext commented@bbrala, you are correct, they are related changes. I agree that working on the different issues concerning 'remove a module from core' does get confusing.
10. The changes to the migration tests are necessary because these tests install the standard profile which will install Color and effect which the list of modules that are upgraded or not upgraded.
10 and 21. The change to HelpTest was done because it was testing sorting and I wanted to keep two items in the list starting with the same letter. This is no longer needed as a previous patch added 'Breakpoint'. The other issue is #3270940: Move all non migration Color tests to the module in preparation of removal.
I started with the patch in #9, rerolled and removed the change to HelpTest.
Comment #24
quietone CreditAttribution: quietone at PreviousNext commentedMissed updating RDF.
Comment #25
andypostUpdated IS, patch looks good, CR exists
not sure about release notes snippet
Comment #26
murilohp CreditAttribution: murilohp at CI&T commentedHey @andypost just trying to help you out here, I've created this new patch for D10 only since #24 is not applying.
Comment #27
murilohp CreditAttribution: murilohp at CI&T commentedMoving back to NR, to see what you think about the reroll.
Comment #28
andypostThank you, RTBC again (there's aggregator in D10)
Comment #31
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!
Comment #32
andypostThank you! the last step is RTBC - #3270936: Deprecate Color module
I'm working on moving code
Comment #33
quietone CreditAttribution: quietone at PreviousNext commentedThe Issue Summary and comments didn't make it clear that there were two patches here, one for D9.4 and one for D10. As a result the D10 patch was committed to D9.4 and the changes to aggregator were missed.
I reckon that on 9.4.x 0ad6705 can be reverted and then the patch in #24 can be committed.
Comment #34
heddnBumping to critical as 9.4 tests are currently failing. And here's a patch with the rollback and application of #24.
Comment #35
andypostAs #34 said 9.4 needs this
Comment #36
yogeshmpawar+1 RTBC
Comment #38
catchCommitted 0e319b4 and pushed to 9.4.x. Thanks!
Restoring status.