Automated Drupal 9 compatibility fixes

I don't understand why this "must have admin theme" is not compatible with Drupal 9 yet. Please correct that ASAP!

I will roll a new release on this weekend. Dont panic :)

That a good news!
And update with the new Drupal logo please.

Good to hear this! :)

Thanks! I'm interested in this as well.

+1

Great to see this is in the pipeline, +1 to D9 compatibility...

A gentle reminder to folks that Drupal exists because of community involvement, almost every line of code is developed and provided for free. Instead of demanding, try offering to help, or if you can't help just provide encouragement. That is the Drupal way.

@andrey.troeglazov - do you need assistance with rolling out the new version?

Hi I have tested with drupal 9.1.x-dev it's still not compatible with d9. Am attaching the screenshot after patch applied

Need to add the core_version_requirement

Hi i have added the patch for this issue, please review.

Attaching screenshot after fix.

Wanted to create the same patch today, @Indrajith KB, but you were quicker ;)

I applied both patches, #2 and #13, and tested on Drupal 8 and 9. Worked with Drupal 8, but in Drupal 9 FILE_EXISTS_ERROR was removed. I updated the patch #2 accordingly.

Since EXISTS_ERROR, that is part of the patch, exists since 8.7.0, we have to update your patch as well, @Indrajith KB. And since "core_version_requirement" was only introduced in 8.7.7, I simply added that version as a requirement, and dropped "core: 8.x" from the file, that would guarantee compatibility for the versions between 8.7.x and 8.7.7.

Just realized I added the second patch as a .diff file, sorry. Here is the same patch as a .patch file.

That constant isn't quite right, its not global its on the FileSystemInterface. Additionally, rector didn't pick it up but file_unmanaged_copy is removed as well. Here's an updated patch that worked for me. I combined the service retrieval since its used in both cases of the if statement.

Additionally, you only need to specify ^8 in the supported versions. Prior to that the line just gets ignored so there's not reason to be that specific.

I combined the two patches using format-patches. If you're not familiar with it you can read more about applying them here but git apply will also handle it just fine.

bah, files didn't get uploaded.

Hi @neclimdul nice work it's fixing our problem...!!!

attaching screenshots

before:

after:

Any plans to release these patches in a release?

please review the patch made on report from upgrade_status module.

I confirm that #16 works for D9 and satisfies Upgrade status module.

Reconforming the manul test

Installation: Patched Successfully via Composer Patch workflow

Functional Test: No issues identified

@satyaki_dutta What is exactly difference between your patch and the patch from #16?
I think the #16 works fine and is better than the #20 patch.

Hope there will be a new release soon so there won't be a composer issue anymore when upgrading to D9:

$ composer update
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: remove drupal/adminimal_theme dev-1.x
    - Conclusion: don't install drupal/core 9.0.3
......
    - drupal/adminimal_theme dev-1.x requires drupal/core ~8.0 -> satisfiable by drupal/core[8.0.x-dev, 8.1.x-dev, 8.2.x-dev, 8.3.x-dev, 8.4.x-dev, 8.5.x-dev, 8.7.x-dev, 8.8.x-dev, 8.9.x-dev].
......

Composer Update Patch working only for #20 File #16 not working

Confirming #20 seems to work

Patch at #16 does not apply to current dev.

This patch is practically the same as #16, but will apply to current dev via composer patches, git apply or plain old patch. Note it restores the core: 8.x line which is commented out in dev for some reason, I believe this defines the minimum core version required, is more easily parsed than core_version_requirement, and may remain present (correct me if I am wrong).

Hmm ... think that dev version I used with the commented-out core requirement was old (23 May), the result of downloading the .tar.gz. Try this patch against 1.5 or current dev (via composer or git checkout) instead.

@John Pitcairn, it would be nice if you could provide an interdiff between #16 and #28 then.

I installed this version + patch #28 yesterday and only found a missing file: /themes/adminimal_theme/logo.svg.
The name of the site is hardly visible: a link in a black background.

@jcnventura: Here's an interdiff, for what it's worth. The patch is more readable than the interdiff. It's basically a re-roll, #16 (actually #17) has a bunch of email cruft in it, which is presumably what prevents it applying for me.

I just would like to ask if this is going to be merged anytime soon with a new released version of adminimal theme. This issue is kind of blocking us for three months already from being able to upgrade to Drupal 9.

FYI if you want to work around Composer prohibiting you to update to Drupal 9 you can do it by changing your composer.json and use the patch provided here.

https://medium.com/@orlando.thoeny/drupal-9-fix-composer-modules-prohibiting-upgrade-6f3452849411

+++ b/adminimal_theme.theme
@@ -50,20 +51,22 @@ function adminimal_theme_form_system_theme_settings_alter(&$form, \Drupal\Core\F
-      file_unmanaged_copy($old_css_path, $custom_css_path, FILE_EXISTS_ERROR);
+      $file_system->copy($old_css_path, $custom_css_path, FileSystemInterface::EXISTS_ERROR);
...
-      file_unmanaged_save_data("", $custom_css_path, FILE_EXISTS_ERROR);
+      $file_system->saveData("", $custom_css_path, FileSystemInterface::EXISTS_ERROR);

https://www.drupal.org/node/3006851

both require ^8.7 so ^8 is not true

I suggest to remove "core: 8.x" at all for core_version_requirement: ^8.8 || ^9

..and create new release as core 8.7 no longer supported

Ref https://www.drupal.org/node/3070687

Agree with @andypost, It's not possible to specify ^8.7 - only ^8.7.7 - so we might as well specify ^8.8 (or ^8.7.7). In any case that line needs to be changed.

Hello, I rectified the patch.

@Fabsgugu can you create a real patch and not simply editing the file from #28. The patch you provided is invalid.

We are currently using the 8.x-1.3 version. I tried applying the latest patch here, but it did not apply.
I also tried updating to latest 8.x-1.5 and applying the patch, and that didn't work either.

I'm also a little confused by this patch, because when i run Drupal check before the patch, I see no D9 deprecation issues, yet there are still some being fixed in this patch. The main part of this patch I think I need for D9 support is the addition of the `core_version_requirement`, but perhaps Drupal-check was wrong and/or missed some deprecations, so I would use this patch if it would apply. Or is it possible those deprecations were fixed and committed already in some other issue?

@joshua.boltz patches are usually created against the dev branch of a module in the first instance. You can check the primary branch for the issue in the metadata section.

I would add a fix code standard

./vendor/bin/rector process web/modules/contrib/adminimal_theme
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

I would add a fix of code standard

Rector 0.8.x-dev@8896f0a
Config file: rector.yml

3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

Hello everyone.
The #43 looks good for me.
Please commit the changes.

Thanks all.
New release: https://www.drupal.org/project/adminimal_theme/releases/8.x-1.6