Provide an example of how to manage robots.txt and .htaccess with Composer

Seems pretty clear and covers the most common use cases.
+1

Questions:

1. +++ b/composer/Plugin/Scaffold/README.md
   @@ -109,8 +114,8 @@ Sometimes, a project might wish to use a scaffold file provided by a dependency,
   +The example below shows a project that prepends additional entries onto the ¶
   

   Is there a trailing white space here or is it dreditor?

2. +++ b/composer/Plugin/Scaffold/README.md
   @@ -135,10 +140,24 @@ to patch the `.htaccess` file using a patch.
   +      "cd web && patch -p1 < ../scaffold-modifications/htaccess.patch"
   

   Would doing the following work as well for non-VCS?

   cd web && cp ../scaffold-modifications/.htaccess ./

3. +++ b/composer/Plugin/Scaffold/README.md
   @@ -135,10 +140,24 @@ to patch the `.htaccess` file using a patch.
   +- Use a git clone of a Composer-managed site.
   +- Create a directory `scaffold-modifications` at the project root.
   +- Go to the scaffold assets directory via `cd core/assets/scaffold/files`.
   +- Edit the `htaccess` file there, and insert your desired modifications.
   +- Create the patch via `git diff htaccess > htaccess.patch`.
   +- Move the `htaccess.patch` file into `scaffold-modifications` in your site.
   +- Remove your modifications via `git checkout -- htaccess`.
   +- Copy the example script command above into your project's composer.json file.
   

   Do these create a hidden dependency on git?

1. +++ b/composer/Plugin/Scaffold/README.md
   @@ -109,8 +114,8 @@ Sometimes, a project might wish to use a scaffold file provided by a dependency,
   +The example below shows a project that prepends additional entries onto the ¶
   

   Additional space on the end of the line

2. +++ b/composer/Template/RecommendedProject/scaffold-modifications/htaccess.patch
   @@ -0,0 +1,57 @@
   ++  ## If your site can be accessed both with and without the 'www.' prefix, you
   ++  ## can use one of the following settings to redirect users to your preferred
   ++  ## URL, either WITH or WITHOUT the 'www.' prefix. Choose ONLY one option:
   ++  ##
   ++  ## To redirect all users to access the site WITH the 'www.' prefix,
   ++  ## (http://example.com/foo will be redirected to http://www.example.com/foo)
   ++  ## uncomment the following:
   ++  ## RewriteCond %{HTTP_HOST} .
   ++  ## RewriteCond %{HTTP_HOST} !^www\. [NC]
   ++  ## RewriteRule ^ http%{ENV:protossl}://www.%{HTTP_HOST}%{REQUEST_URI} [L,R=301]
   ++  ##
   ++  ## To redirect all users to access the site WITHOUT the 'www.' prefix,
   ++  ## (http://www.example.com/foo will be redirected to http://example.com/foo)
   ++  ## uncomment the following:
   ++  ## RewriteCond %{HTTP_HOST} ^www\.(.+)$ [NC]
   ++  ## RewriteRule ^ http%{ENV:protossl}://%1%{REQUEST_URI} [L,R=301]
   

   I'm not sure why the .patch file is double commenting these lines?

3. +++ b/composer/Template/RecommendedProject/scaffold-modifications/robots.txt.prepend
   @@ -0,0 +1,6 @@
   +## DO NOT MODIFY THIS FILE DIRECTLY. This file is managed by Composer, and
   +## should not be edited in place.
   +##
   +## This header was prepended from the text file 'robots.txt.prepend'.
   +## For more information on how to manage alterations to scaffold files, see:
   +## https://github.com/drupal/core-composer-scaffold#altering-scaffold-files
   

   This is an odd one but I think once this lands all projects built on the recommended project template are going to have a scaffold-modifications directory with this file in it. The text in the file is telling you not to modify it when actually we want you to modify the robots.txt.prepend file.

   I think the files that should have this text are in core/assets/scaffold/files. Not sure we should be adding this text using Scaffold operations.

Sorry if I'm late to this—but for SEO reasons, I do modify my robots.txt, in addition to having a robots_noindex.txt file.

Has it been resolved on how to do this properly with drupal-scaffold?

This is a great idea. I recently created #3151695: Dissuade users from editing .htaccess in the same spirit.

Patch #3 is still applying on D-9.1.x.

I have addressed point 1 of comment #8.

Need work for remaining points of comment #8.

Should there also be an example/hint for drupal/legacy-project, regarding the directory structure and the "scripts" part?

Everything worked for me except this line:

+++ b/composer/Plugin/Scaffold/README.md
@@ -135,10 +140,24 @@ to patch the `.htaccess` file using a patch.
+      "cd web && patch -p1 < ../scaffold-modifications/htaccess.patch"

This worked instead:

patch -p1 < scaffold-modifications/htaccess.patch

I created the htaccess patch following the instructions in composer/Plugin/Scaffold/README.md

Rerolled patch 3095214-16.patch against 11.x branch and updated web-root directory to web in all places instead of mixed docroot and web , updated patch generation git command to include --no-prefix

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Tests failed due to missing patch utility in the docker image. Hence setting to NR again.

git check-ignore 'vendor'
> post-drupal-scaffold-cmd: cd web && patch -p1 <
../scaffold-modifications/htaccess.patch
Executing command (CWD): cd web && patch -p1 <
../scaffold-modifications/htaccess.patch
sh: 1: patch: not found
Script cd web && patch -p1 < ../scaffold-modifications/htaccess.patch
handling the post-drupal-scaffold-cmd event returned with error code 127
Failed asserting that 127 matches expected 0.

Seems this postponed on #3417586: Add the patch utilities back to the drupalci image

Seems to have some test failures