Linkchecker relies on Dynamic Entity Reference ^1.0. The module cannot be installed when using the newer 2.x branch of Dynamic Entity Reference.

I have not yet investigated what is needed to support the 2.x branch.

CommentFileSizeAuthor
#4 interdiff-3092304-3-4.txt327 bytesJeroenT
#4 3092304-4.patch785 bytesJeroenT
#3 3092304-3.patch784 bytesJeroenT

Issue fork linkchecker-3092304

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

commonColby created an issue. See original summary.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann at Nodegard commented
Category: Support request » Bug report

Without checking the complete situation I'm sure we need this compatibility.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Active » Needs review
FileSize
3092304-3.patch784 bytes

Step 1 to use dynamic_entity_reference V1 and V2.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3092304-4.patch785 bytes
interdiff-3092304-3-4.txt327 bytes
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Category: Bug report » Support request

In my opinion this is not a bug since DER is still alpha and actually not ready for production sites.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann at Nodegard commented
Category: Support request » Bug report
Issue tags: -dependency +ContributionWeekend2020

@JeroenT When linkchecker has a dependency on another module we need to take care of it especially when it's not stable. So I think this is a bug.

But even when we won't call this a bug. It's more than a "Support Request" which is for helping users on an individual projects. And usually a support request won't end up in patches :-). By the way: Thanx for fixing the dependency. I will check the patch ASAP.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann at Nodegard commented
Title: Provide support for Dynamic Entity Reference 2.x » Add support for Dynamic Entity Reference 2.x
Issue summary: View changes
C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann at Nodegard commented
Category: Bug report » Feature request

OK, as long Version 2 is alpha we can handle this like feature request. When the patch won't force using an unstable dependency instead of the stable one I will be open for it.

C_Logemann opened merge request !3

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann at Nodegard commented

As the patch won't apply anymore I decided to use the new issue fork system for creating a re-roll.

  • C_Logemann committed 98e2a85 on 8.x-1.x 
    Issue #3092304 by JeroenT, C_Logemann: Add support for Dynamic Entity...
C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann at Nodegard commented
Status: Needs review » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Thanks JeroenT & Others

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.