Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/twitter_block d65f11c927883504d01728eb4fcdb3974e4e85cb
source : http://cgit.drupalcode.org/twitter_block

Pareview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-twitter_block-...

Drupal check report

./vendor/bin/drupal-check modules/contrib/twitter_block/
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------- 
  Line   src/Tests/TwitterBlockTest.php                                              
 ------ ---------------------------------------------------------------------------- 
  12     Class Drupal\twitter_block\Tests\TwitterBlockTest extends deprecated class  
         Drupal\simpletest\WebTestBase.                                              
  25     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase.   
 ------ ---------------------------------------------------------------------------- 

                                                                                             
 [ERROR] Found 2 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 interdiff_3-8.txt1.45 KBLilit_Ghazaryan
#8 3042776-8.patch3.46 KBsidharthap
#3 3042776-Drupal9_Deprecated_code_report.patch2.36 KBnikolas.tatianenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcdwayne created an issue. See original summary.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Issue summary: View changes

Add the Pareview checklist link, and fix the issues into it's children issues.

Thank you.

nikolas.tatianenko’s picture

nikolas.tatianenko CreditAttribution: nikolas.tatianenko at EPAM Systems commented
FileSize
3042776-Drupal9_Deprecated_code_report.patch2.36 KB

Hi All,
Please review.

nikolas.tatianenko’s picture

nikolas.tatianenko CreditAttribution: nikolas.tatianenko at EPAM Systems commented
Status: Active » Needs review
margaritka.kurkul’s picture

margaritka.kurkul CreditAttribution: margaritka.kurkul at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Tested and verified on phpcs locally. There are no errors in files:
src/Plugin/Block/TwitterBlock.php
src/Tests/TwitterBlockTest.php

John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
Issue tags: +ContributionWeekend2020

The drupal-check tool shows that there are some outstand deprecated code errors.

./vendor/bin/drupal-check modules/contrib/twitter_block/
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------- 
  Line   src/Tests/TwitterBlockTest.php                                              
 ------ ---------------------------------------------------------------------------- 
  12     Class Drupal\twitter_block\Tests\TwitterBlockTest extends deprecated class  
         Drupal\simpletest\WebTestBase.                                              
  25     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase.   
 ------ ---------------------------------------------------------------------------- 

                                                                                             
 [ERROR] Found 2 errors

These will need to be fixed as well. (I've added the report to the summary as well).

Setting back to 'needs work' to fix the deprecated code.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap at TATA Consultancy Services for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
3042776-8.patch3.46 KB

Patch to address #6 comments.

Lilit_Ghazaryan’s picture

Lilit_Ghazaryan CreditAttribution: Lilit_Ghazaryan at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff_3-8.txt1.45 KB

Reviewed and tested #8 patch and created interdiff file for #3 - #8 patches

vendor/bin/rector process web/modules/contrib/twitter_block/ --dry-run
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

Lilit_Ghazaryan’s picture

Lilit_Ghazaryan CreditAttribution: Lilit_Ghazaryan at EPAM Systems commented
Issue tags: +Drupal 9 porting weekend
nikolas.tatianenko’s picture

nikolas.tatianenko CreditAttribution: nikolas.tatianenko at EPAM Systems commented
Issue tags: +epam-contrib

Lilit_Ghazaryan, margaritka.kurkul and me were contributed during Epam Contribution event

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.