Fixing Array to String Notice for PHP 7.x [#2989199]

Comment	File	Size	Author
#15	material_admin-v2-array_to_string_notice-2989199-15.patch	959 bytes	ocastle
#9	material_admin-array_to_string_notice-2989199-9.patch	959 bytes	mvonfrie
#7	implode-argument-must-be-array-2989199-7.patch	836 bytes	xpersonas
#5	material_admin-array_to_string_notice-2989199-5-D8.patch	831 bytes	reszli
#3	warning-msg.txt	7.74 KB	sergei_semipiadniy
#3	material_admin-array_to_string_notice-2989199-2-D8.patch	778 bytes	sergei_semipiadniy
	array-to-string-notice-fix-1.patch	657 bytes	xpersonas

Comment #1

30 July 2018 at 15:38

xpersonas created an issue. See original summary.

Log in or register to post comments

Comment #3

sergei_semipiadniy commented 10 August 2018 at 12:54

Version:	8.x-1.0-alpha6	» 8.x-1.x-dev
Status:	Active	» Needs review

Status	File	Size
new	material_admin-array_to_string_notice-2989199-2-D8.patch	778 bytes
new	warning-msg.txt	7.74 KB

Hi,

@xpersonas, I installed fresh drupal 8.5.6 and faced with a warning, probably, that has been appeared after this fix.

File with dump of a warning is enclosed, as well as a fresh patch.

Regards

Log in or register to post comments

Comment #4

jwjoshuawalker commented 6 September 2018 at 16:49

Same error here. The patch fixes it, but I feel like we could do this more cleanly.

Log in or register to post comments

Comment #5

reszli

he/him

Hungarian

Târgu Mureș

commented 19 October 2018 at 07:04

Status	File	Size
new	material_admin-array_to_string_notice-2989199-5-D8.patch	831 bytes

slightly modified patch to remove all errors
I agree that this is probably not the best way, but who's in a hurry...

Log in or register to post comments

Comment #6

mariagwyn commented 3 December 2018 at 21:07

I can confirm that the patch silences the error.

Log in or register to post comments

Comment #7

xpersonas commented 20 December 2018 at 12:59

Status	File	Size
new	implode-argument-must-be-array-2989199-7.patch	836 bytes

I'm debating if this should be a new issue, but it involves the exact same piece of code so i'm putting it here. I'm getting a notice about the implode function in this check....

Warning: implode(): Argument must be an array

I have a new patch that breaks the argument into two lines, checking that it's an array first. If you guys have a better way to handle, let me know. But this is working for me at the moment.

Log in or register to post comments

Comment #8

mvonfrie commented 5 March 2019 at 20:00

I have the exact same issue with Drupal 8.6.10 now and figured out that $variables['attributes']['placeholder'] can be a string instead of an array, either empty or with a placeholder value (e. g. for a Drupal Commerce price field the default placeholder is 9,99 and "9.99" == $variables['attributes']['placeholder'].

According to https://secure.php.net/manual/en/function.implode.php the implode function has two signatures:

implode(string = "", array)
implode(array)

If $variables['attributes']['placeholder'] is expected to be an array as in all previous patches but actually is a string, none of the implode function matches because the string is optional and the array is required.