$this->t() should be used instead of t() in /src/Plugin/ViewsSlideshowWidget PagerFields class.

CommentFileSizeAuthor
#5 interdiff_2-5.txt33.53 KBdhruveshdtripathi
#5 this_t_should_be-2862100-5.patch35.26 KBdhruveshdtripathi
#2 this_t_should_be_used_instead_of_t-2862100-2.patch2.09 KBhiramanpatil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hiramanpatil created an issue. See original summary.

hiramanpatil’s picture

hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commented
FileSize
this_t_should_be_used_instead_of_t-2862100-2.patch2.09 KB

Please find attached patch file.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Assigned: hiramanpatil » Unassigned
Status: Active » Needs review

just triggering test bot

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi
Status: Needs review » Needs work

Few t() are yet to be replaced with $this->t().

Working on it.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
this_t_should_be-2862100-5.patch35.26 KB
interdiff_2-5.txt33.53 KB

Remaining and necessary t() functions replaced with $this-t() function. Interdiff added.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs review » Fixed

applied, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.