Problem/Motivation

Starting May 29, 2016 - 20:10 the automated tests for this module (7.x-2.x-dev version) started failing the GMap.LGFATestCase.

As a result of this, all contributed patches starting failing on what seems to be a module issue.

Proposed resolution

- Identify what was changed on my 29th.
- Update the test accordingly.

CommentFileSizeAuthor
#5 repair_the_failing-2778721-5.patch436 bytesNeograph734
#3 repair_the_failing-2778721-3.patch540 bytesNeograph734
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neograph734 created an issue. See original summary.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented
Title: Repair the failing GMap.LGFATestCase » Repair the failing testGmapSaveConfig test
Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented
Status: Active » Needs review
FileSize
repair_the_failing-2778721-3.patch540 bytes

This was caused by the 'administer fields' permission that was introduced with Drupal 7.50 (changelog). The test has been updated to also grant this permission to the privileged_user in the test.

Status: Needs review » Needs work

The last submitted patch, 3: repair_the_failing-2778721-3.patch, failed testing.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented
Status: Needs work » Needs review
FileSize
repair_the_failing-2778721-5.patch436 bytes

Let's try this...

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented
Title: Repair the failing testGmapSaveConfig test » [Patch Blocker] - Repair the failing testGmapSaveConfig test
Status: Needs review » Reviewed & tested by the community
MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented

Nice find.

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Priority: Major » Critical

So this is a blocker for all other patches in the issue queue, bumping priority accordingly.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, FFW, Drupal Ukraine Community for Drupal Ukraine Community commented

Thanks for the fix
Committing

  • podarok committed cb8a3de on 7.x-2.x authored by Neograph734 
    Issue #2778721 by Neograph734: [Patch Blocker] - Repair the failing...
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, FFW, Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed
MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.