file_entity_field_formatter_view() not working with Entity Embed

Tested #2 and committed with some additional code cleanup.

I just updated from the february dev to april 21 dev and my images are now not displaying.

Line 286 of file_entity_field.inc now has:

foreach ($items as $delta => $item) {
        if (!empty($item['file'])) {
          $files[$item['fid']] = $item['file'];
        }
      }

If I dsm($Item) it has $item['fid'] but not $item['file']. The $item appears to be the file. So the test if ($empty($item['file'])) is failing...and no images are being displayed.

I think there's also a problem with the follow-up committed with http://cgit.drupalcode.org/file_entity/commit/?id=f74eb9a - we need to make sure that we're returning the field formatter output indexed by the correct $delta values.

Based on file_field_load() and what all of our other formatters do, we should be converting $item to an object to render it. I also wanted to simplify and unify this with the entity reference field formatter.

Updated correct call to file_view().

Also, I'm *pretty sure* we're going to break something outside of this module with this removal of this code:

        $files_display[$fid]->referencing_entity = $entity;
        $files_display[$fid]->referencing_entity_type = $entity_type;
        $files_display[$fid]->referencing_field = $field['field_name'];

That code came with #2333107: Allow file formatter to known the type of the referencing entity.

This re-adds the references. I tried to go back through all the code that touched this formatter to make sure we are accounting for regressions. #1784762: File description lost when using Rendered file formatter and Generic file display is accounted for since $item['description'] will get converted to $file->description now.

Got rid of the exception and just logging it instead now, more like D8.

Using more D8 style of counting recursion, but left out $instance['bundle'] because it seems like Entity Embed in D7 doesn't have $instance['bundle'].

Hello,

The commit related to this issue…

http://cgit.drupalcode.org/file_entity/commit/?id=e17e4b82793b4e8c5ea6e9...

And possibly related to the cleanup after…

http://cgit.drupalcode.org/file_entity/commit/?id=f74eb9a856c4443366e332...

…caused our sites not to be able to render files referenced by both views and panels.

Reverting the cleanup commit seemed to get the files back, but then I had the errors. Reverting both got everything working back to normal. We are not using the Entity Embed module so I'm not sure how that relates.

Not sure where to go from here other than letting you know the above changes broke our installs.

Please let me know if you have any questions.

Thanks,

•• matt

Committed #14 to 7.x-2.x.