CommentFileSizeAuthor
#1 Issue-2486211-by-hass-Use-image-theme-function-for-i.patch1.54 KBhass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented
Status: Active » Needs review
FileSize
Issue-2486211-by-hass-Use-image-theme-function-for-i.patch1.54 KB

We may also need to set

'#cache' => [
  'max-age' => 0,
],

#2486213: Provide Cache::NEVER constant

Status: Needs review » Needs work

The last submitted patch, 1: Issue-2486211-by-hass-Use-image-theme-function-for-i.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review

DEV is broken

hass’s picture

hass CreditAttribution: hass commented

#cache seems not required here.

How have you managed to disable the cache for the form image???

hass queued 1: Issue-2486211-by-hass-Use-image-theme-function-for-i.patch for re-testing.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k at Propeople (now part of FFW) for Propeople (now part of FFW) commented

Is lazy_loader is applicable here?

hass’s picture

hass CreditAttribution: hass commented

You mean placeholders? This can bei opzimized with the new placeholder feature and I guess this makes this code cachable, too. No longer a need for the page cache killswitch.

But this can be done in a followup... It is not directly related to my patch.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k at Propeople (now part of FFW) for Propeople (now part of FFW) commented
Status: Needs review » Reviewed & tested by the community

Then it looks and works fine - RBTC

  • elachlan committed 8dfdd2f on 8.x-1.x authored by hass 
    Issue #2486211 by hass, m1r1k: Use image theme function for image...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Reviewed & tested by the community » Fixed
hass’s picture

hass CreditAttribution: hass commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Patch (to be ported)
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Patch (to be ported) » Fixed

Closing as fixed for 8,x-1.x as it seems nobody wants to do the Drupal 7 backport ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.