Problem/Motivation

Speed up testbot and simplify tests by using the testing profile instead of the standard profile.

Steps to reproduce

Proposed resolution

Convert Drupal\node\Tests\NodeAccessBaseTableTest to use the testing profile, not the standard profile.

Remaining tasks

Update patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#23 interdiff_22-23.txt476 bytespooja saraah
#23 2254175-23.patch6.42 KBpooja saraah
#22 2254175-22.patch6.42 KBsmustgrave
#22 interdiff-20-22.txt4.75 KBsmustgrave
#20 2254175-20.patch704 bytessmustgrave
#20 interdiff-19-20.txt612 bytessmustgrave
#19 2254175-19.patch749 bytessmustgrave
#5 comment-preview-test-is-puke-2254175.1.patch5.51 KBlarowlan
testperf.comment-CommentPreviewTest.patch1.09 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, testperf.comment-CommentPreviewTest.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » larowlan

yeah 6 mins for one test locally (puke).

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: larowlan » Unassigned
Status: Needs work » Needs review

No interdiff, new patch.

~6 mins » ~ 2mins on local

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
StatusFileSize
new comment-preview-test-is-puke-2254175.1.patch5.51 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Postponed

Postponed on #2551959: Hardcoded usage of compact view mode in template_preprocess_node() and template_preprocess_comment() is problematic and #1972242: User compact view mode is not configured in minimal

mgifford’s picture

mgifford
he/him
Primary language English
commented
Related issues: +#1972242: User compact view mode is not configured in minimal

Node #2551959 doesn't seem to exist.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Version: 9.3.x-dev » 10.0.x-dev
Issue summary: View changes
Parent issue: #1595028: Convert tests using Standard profile to use Testing profile instead » #3270566: [meta] Convert remaining tests using Standard profile to use Testing profile instead
Related issues: +#1595028: Convert tests using Standard profile to use Testing profile instead

Adding issue summary and re-parenting.

smustgrave’s picture

smustgrave commented
Status: Postponed » Needs review
StatusFileSize
new 2254175-19.patch749 bytes

This may fail but we will see.

smustgrave’s picture

smustgrave commented
StatusFileSize
new interdiff-19-20.txt612 bytes
new 2254175-20.patch704 bytes

Fixed CI issue.

Status: Needs review » Needs work

The last submitted patch, 20: 2254175-20.patch, failed testing. View results

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-20-22.txt4.75 KB
new 2254175-22.patch6.42 KB
pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 2254175-23.patch6.42 KB
new interdiff_22-23.txt476 bytes

Fixed failed commands on #22
Attached patch against Drupal 10.0.x

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Looks good and is passing

  • catch committed 557fc49 on 10.0.x 
    Issue #2254175 by smustgrave, pooja saraah, larowlan, sun: Fix test...
  • catch committed 9baae1b on 10.1.x
    Issue #2254175 by smustgrave, pooja saraah, larowlan, sun: Fix test...

  • catch committed 863e9e7 on 9.5.x 
    Issue #2254175 by smustgrave, pooja saraah, larowlan, sun: Fix test...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.