Replace all module_invoke() deprecated function calls.

I'm working on it.

I upload the patch with all the replacements.

I'll try to fix it

If the file has a namespace, you'll have to use a global path instead of relative, like so:

-Drupal::moduleHandler()->invoke(...);
+\Drupal::moduleHandler()->invoke(...);

Thank you michael! I added \Drupal... to every module file and fixed the self ModuleHandler class wich I forgot to switch to $this->invoke(). Uploading the patch and interdiff

I'll do it again!

Uploading a new patch from scratch

Previous patch doesn't apply so I started again from scratch.

I've resolved a little mistake I made yesterday.

Going back to module_invoke() at OO code.

I've created the OO task in #2055333: Replace module_invoke() deprecated function calls in OO code

The patch doesn't apply so I'll re-roll it as soon as possible.

Re-rolled.

Uploading a new patch from scratch.

Re-rolled.

Needs a reroll.

Checking patch core/includes/common.inc...
Checking patch core/includes/install.inc...
Checking patch core/includes/schema.inc...
Checking patch core/includes/update.inc...
Checking patch core/modules/comment/comment.admin.inc...
Checking patch core/modules/field/field.attach.inc...
Checking patch core/modules/field/field.crud.inc...
Checking patch core/modules/field/field.info.inc...
Checking patch core/modules/field/field.views.inc...
Checking patch core/modules/file/file.module...
Hunk #1 succeeded at 670 (offset 9 lines).
Checking patch core/modules/node/node.module...
Checking patch core/modules/node/node.pages.inc...
Hunk #1 succeeded at 85 (offset 1 line).
Checking patch core/modules/search/search.api.php...
Checking patch core/modules/search/search.module...
error: while searching for:

  foreach (config('search.settings')->get('active_modules') as $module) {
    // Update word index
    module_invoke($module, 'update_index');
  }
}


error: patch failed: core/modules/search/search.module:364
error: core/modules/search/search.module: patch does not apply
Checking patch core/modules/system/system.module...
Hunk #1 succeeded at 2983 (offset -35 lines).
Checking patch core/modules/system/tests/modules/module_test/module_test.module...
Checking patch core/modules/taxonomy/taxonomy.admin.inc...
Checking patch core/modules/user/user.admin.inc...
Checking patch core/modules/user/user.module...

Tagging.

Re-rolled.

Thanks @juanolalla! Removing Needs review tag, we have a status for that :)

Ups! Sorry, I don't know what happened, uploading re-roll patch.

bold text

The patch no longer applies; it needs to be rebased.

Rerolled patch from #31.

Changes in the following files could not be applied because the code was not there anymore.

• comment.admin.inc
• field.info.inc
• field.purge.inc
• field.views.inc
• node.module
• node.pages.inc
• search.api.php
• search.module
• taxonomy.admin.inc
• user.admin.inc

Leavings issue status at 'needs work'. Some 35 implementations of module_invoke() still remain in core.

I miscounted (also counted the module_invoke_all()). Only 2 remained and 3 in comment or text.
I did not remove the function module_invoke() itself, as similar issues don't do that too.

Let's see what testbot says...

One wrong call of moduleHandler()->invoke() found. I've rand found of the failing test and all passed.

oeps, did not notice #39 coming

According to the #2053489: Standardize on \Drupal throughout core \Drupal::foo() should be used instead of Drupal::foo().

Should this issue also add dependency injections since it introduces the use of module_handler service in classes? (i.e. Drupal\node\NodeFormController::form() and Drupal\user\Plugin\views\access\Permission::buildOptionsForm())

Re-roll. I also removed module_invoke() itself, as related issues do it too, and it helps us make sure there is absolutely no other code still using it.

Should this issue also add dependency injections since it introduces the use of module_handler service in classes?

Let's do that in follow-ups, where we can also unit test those classes. It would be out of scope for this issue.

Re-roll.

Patch still applies and looks good to me

Re-roll.

Re-roll.

https://drupal.org/node/1894902 looks like it already covers the API change for this, so I've simply added a reference to this issue there.

Committed 98cdbfe and pushed to 8.x. Thanks!

Reverted as this broke drush which is used by PIFR. Committed 12953f2 and pushed to 8.x

This cause a HEAD fail: PHP Fatal error: Call to undefined function module_invoke() in /opt/drush/classes/DrushRole.php on line 227

https://github.com/drush-ops/drush/issues/452

We could just roll a patch without the function removal for now.

This version doesn't remove module_invoke. Instead, I've updated its comment to avoid a conflict with the latest patch on #2045927: Replace all drupal_alter() deprecated function calls. and included the change from #2187735: Add removal information to docblock of all @deprecated functions to make the reroll on that one as easy as possible.

Comment is now (changes in bold)

/**
* Invokes a hook in a particular module.
*
* All arguments are passed by value. Use \Drupal::moduleHandler()->alter() if
* you need to pass arguments by reference.
*
* @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0. Use
* \Drupal::moduleHandler()->invoke($module, $hook, $args = array()).
*
* @see \Drupal\Core\Extension\ModuleHandler::alter()
* @see \Drupal\Core\Extension\ModuleHandler::invoke()
*/

I think this needs to be listed on https://drupal.org/node/1894902

And https://drupal.org/node/1816456 needs to be updated.

I've updated those change records so I think this is ready for RTBC again. Does anyone agree?

I've checked the changes between #54 and #59 patches. Ok
I've checked the change in the Change Records. Ok
I've checked for any other Change Records containing module_invoke. Non applicable to change.
I've checked for remaining module_invoke() usage after this patch. None found.
Patch still applies.

All green, so back to RTBC.

Removing tag 'Needs change record'.

Committed 5c1c02f and pushed to 8.x. Thanks!