As commented in https://drupal.org/node/2045931#comment-7697279 instead of replacing all module_invoke() function calls with \Drupal::moduleHandler()->invoke() we should see how can the ModuleHandler be injected in each case.

This issue is part of #2045921: Replace all module_invoke() deprecated function calls.

Meta Issue.
#1916134: Remove module_* deprecated functions

CommentFileSizeAuthor
#4 replace_deprecated_module_invoke-2055333-4.patch5.72 KBjuanolalla
#4 interdiff.txt4.73 KBjuanolalla
#2 replace_deprecated_module_invoke-2055333-2.patch9.45 KBjuanolalla

Comments

juanolalla’s picture

juanolalla commented
Assigned: Unassigned » juanolalla

I'm doing it

juanolalla’s picture

juanolalla commented
Status: Active » Needs review
StatusFileSize
new replace_deprecated_module_invoke-2055333-2.patch9.45 KB

I upload the patch.

Status: Needs review » Needs work

The last submitted patch, replace_deprecated_module_invoke-2055333-2.patch, failed testing.

juanolalla’s picture

juanolalla commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt4.73 KB
new replace_deprecated_module_invoke-2055333-4.patch5.72 KB

I didn't realize that the three controllers already have ModuleHandler injected extending EntityFormController. I upload the patch fixing it.

Status: Needs review » Needs work

The last submitted patch, replace_deprecated_module_invoke-2055333-4.patch, failed testing.

juanolalla’s picture

juanolalla commented
Status: Needs work » Needs review

#4: replace_deprecated_module_invoke-2055333-4.patch queued for re-testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

jacob.embree’s picture

jacob.embree commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

This issue is fixed. module_invoke() no longer appears in core.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.