Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I will not alter code flow. If I find problems in a file, which I will not fix, but find suspicious. I'll mention it in the text here.
For changes in the PHP Documentation I use this node as guide: http://drupal.org/node/1354
What are my main tasks:
- I usually add types to PHPDoc structures (main task for me)
- Remove unused variables inside function, when no meaning is found what so ever
- Unharmful declare variables which are used without init if mentioned and logically by my IDE
- I add "array" to function signatures if that is the only possible and requested type for that argument.
- Adding @throws to PHPDoc if an Exception can be occur inside a function
- I do not touch any kind of unit test files. Not even the documentation of functions inside
Checked: XMLRPC module file.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | interdiff-19674303-3-10.txt | 11.09 KB | fgm |
| #11 | 19674303-optional_args-10.patch | 12.91 KB | fgm |
| #3 | drupal_core-code_cleanup_apidoc_cleanup-xmlrpcmodule19674303.patch | 8.88 KB | InternetDevels |
| #3 | interdiff-1967430-0-3.txt | 1.79 KB | InternetDevels |
| drupal_core-code_cleanup_apidoc_cleanup-xmlrpc_module.patch | 10.04 KB | ro-no-lo |
Comments
Comment #0.0
ro-no-lo CreditAttribution: ro-no-lo commentedRemoved a $ sign.
Comment #0.1
ro-no-lo CreditAttribution: ro-no-lo commentedAdded Details.
Comment #1
areke CreditAttribution: areke commentedOk, I guess the patch looks fine; however, it does need to be rebased against the current HEAD.
Comment #2
zvischutz CreditAttribution: zvischutz commentedwill take the re-roll on me
Comment #3
InternetDevels CreditAttribution: InternetDevels commentedComment #4
PawelR CreditAttribution: PawelR commentedLooks good to me.
Comment #5
amateescu CreditAttribution: amateescu commentedUnfortunately, that's not really true even almost a year after this issue was opened.
The patch does look good but there's a big architectural cleanup patch for the XML-RPC system at #1979040: Rewrite XML RPC module to services and plugins that will be very painful to reroll if this gets in. Can we please postopone it on that issue?
Comment #6
alexpottYes we can - postponed on #1979040: Rewrite XML RPC module to services and plugins and #1285726: Remove XML-RPC
Comment #7
gregglesAfter #1285726-48: Remove XML-RPC moving this to the contributed module home for xmlrpc issues.
Back to rtbc for contrib?
Comment #9
drummComment #11
fgmRerolled now that it's in contrib, adding a number of missing comments, too.
Also changed call signature : false|string|array doesn't cover it entirely, as results may be struct/array too, so it's just a "mixed" IMO.
Comment #13
fgmCommitted to 8.x-1.x, thanks.