$account->getDisplayName() should be used when outputing username in RDF module

In D8 format_username() has become user_format_name(). A patch that calls it for the RDF header on user profiles is attached.

Yes, right.

A new patch is attached that also changes the four references to ->name from the tests to user_format_name(). The RDF tests ran cleanly on my box after these changes.

Verifying that the patch works on 8.0-dev.

We have the same issue in D7 since we use realname module to separate first and last name. Would be great if this could be ported to D7.

Looks good to me.

Applied the patch in #3 to the latest version of D8 with no problem. It passed tests and the output looked good after applying.

In reviewing this I realised we actually weren't really testing whether or not RDF output was using altered names as a result of using user_format_name() so I've added a test module that implements hook_user_format_name_alter(). This exposed two things... CommentAttributesTest wasn't actually testing unverified users properly and we have an issue with user names longer than 20 characters.. the patch attached fixes the first issue but the second issue is bigger and out-of-scope so I'll raise a separate issue for it.

The promised issue... #1992954: Trimming of long usernames results in incorrect RDF

#8: 1929420-rdf-username.8.patch queued for re-testing.

All good. With this test we aren't ensuring that user_format_name() does the alter, but that's not the point, we're ensuring RDF definitely uses user_format_name() and doesn't undo or degrade it somehow.

#8: 1929420-rdf-username.8.patch queued for re-testing.

Quite right, updated that part of the code comment, patch and interdiff attached.

re-rolled patch from #15 and ran simpletest Drupal\rdf\Tests\CommentAttributesTest locally --success this time! 118 passes, 0 fails, 0 exceptions, and 16 debug messages (field o' green... nice!)

queued for testing

reroll and posting for testing

patch for short-term review --more work to come on it

rerolled patch; it was same as comment #26 --queuing for testing

#26 is failing because it's causing a bunch of non-related tests to fail because it changes drupalLogin() to use $account->get('name')->value instead of get->Username().

That's fine for user entities but other tests provide a session object instead of an entity. Going to take a look at the issue #2112679 which scor created above as that might make the use get->Username() work fine.

user_format_name() has been deprecated, we should just call ->getUsername() on the $account object ourselves.

I'll update the patch here to only include that test.

Here's the patch just with updated test for comment attributes. Requires the pending patch in #2112679-29: getUsername() should return the username getDisplayName() for the formatted user name so it will fail.

Merging 1929420-36-user-displayname-test.patch and 2112679-get_username-29.patch to test if they work together after talking to scor about it. Fails when running tests on localdev, but to rule out that it is not just my local dev I am posting it to see what the testbot says.

On local the errors are:

Comment type found in RDF output (sioct:Comment).	Other	CommentAttributesTest.php	239	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment type found in RDF output (sioc:Post).	Other	CommentAttributesTest.php	245	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment subject found in RDF output (dc:title).	Other	CommentAttributesTest.php	253	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment date found in RDF output (dc:date).	Other	CommentAttributesTest.php	261	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment date found in RDF output (dc:created).	Other	CommentAttributesTest.php	268	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment body found in RDF output (content:encoded).	Other	CommentAttributesTest.php	276	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment relation to author found in RDF output (sioc:has_creator).	Other	CommentAttributesTest.php	286	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()

Comment type found in RDF output (sioct:Comment).	Other	CommentAttributesTest.php	239	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment type found in RDF output (sioc:Post).	Other	CommentAttributesTest.php	245	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment subject found in RDF output (dc:title).	Other	CommentAttributesTest.php	253	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment date found in RDF output (dc:date).	Other	CommentAttributesTest.php	261	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment date found in RDF output (dc:created).	Other	CommentAttributesTest.php	268	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment body found in RDF output (content:encoded).	Other	CommentAttributesTest.php	276	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
Comment relation to author found in RDF output (sioc:has_creator).	Other	CommentAttributesTest.php	295	Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup()	Fail
InvalidArgumentException: $resource cannot be null in EasyRdf_Graph->checkResourceParam() (line 433 of /Library/WebServer/Documents/d8/core/vendor/easyrdf/easyrdf/lib/EasyRdf/Graph.php).
EasyRdf_Graph->checkResourceParam(NULL)
EasyRdf_Graph->hasProperty(NULL, 'http://xmlns.com/foaf/0.1/name', Array)
Drupal\rdf\Tests\CommentAttributesTest->_testBasicCommentRdfaMarkup(Object, Object)
Drupal\rdf\Tests\CommentAttributesTest->testCommentRdfaMarkup()
Drupal\simpletest\TestBase->run()
_simpletest_batch_operation(Array, '8', Array)
call_user_func_array('_simpletest_batch_operation', Array)
_batch_process()
_batch_do()
_batch_page(Object)
Drupal\system\Controller\BatchController->batchPage(Object)
call_user_func_array(Array, Array)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1)
Drupal\Core\HttpKernel->handle(Object, 1, 1)
Drupal\Core\DrupalKernel->handle(Object)
drupal_handle_request()
Uncaught exception	Graph.php	433	EasyRdf_Graph->checkResourceParam()

woops, wrong naming convention for the testbot

Setting to needs review for test bot.

Here's the fixed patch for the comment attributes test and a combined patch with #2112676-34 for mr. testbot.

What's the status of this given #1977028: Remove RDF module from core?

Also, patch no longer applies.

Patch Rerolled!

The patch in #42 applies, it just fails tests because the tests it introduces remain dependent on #2112679: getUsername() should return the username getDisplayName() for the formatted user name which has not yet been committed. That's why #42 also contains a combined patch. Setting 2112679 as parent issue.

The previous patch is way too small and appears to be missing the user_name_test module

If this isse has a dependency on #2112679: getUsername() should return the username getDisplayName() for the formatted user name would it be appropriate to mark this issue as postponed?

better to scope the issue to rdf module and merge with "getDisplayName()" if will be allowed

This issue a just a bug report

I assume "cleared as there is no security concerns" means that there is no XSS risk, however it is a minor security fail by exposing the login name, thus bumping priority accordingly.

site is doing something terrible like setting the account name

Debatable on terrible; the entire need for a separate username and email address is terrible and old fashioned IMHO (forcing the need to create two separate unique properties per account)

Anyone who is across this issue able to update in light of getUsername being deprecated?

The fix for this was committed back in 2015 but the tests were not updated. They should be changed to confirm that the altered name is displayed. This patch should do that.

Started tests on 9.1.x, Update title and move to 9.1.x.

+++ b/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php
@@ -187,12 +194,13 @@ public function testCommentRdfaMarkup() {
+    $anonymous = User::load('0');

Nit: I think 0 should be an integer and not a string here.

Otherwise this looks good.

@longwave, thanks.

Fix for the nit in #68.

Thanks for fixing, RTBC assuming tests pass.

+++ b/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php
@@ -24,7 +25,7 @@ class CommentAttributesTest extends CommentTestBase {
+  protected static $modules = ['views', 'node', 'comment', 'rdf', 'user_hooks_test'];

minor nit: can be fixed on commit - this is now > 80 chars so the entries should be on their own line

Other than that, this looks ready in my book, I'll circle back once commit freeze is over

Adding issue credit for those who have provided reviews, issue summary updates

Fixed on commit

diff --git a/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php b/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php
index 5989a55b44..dd913bfabf 100644
--- a/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php
+++ b/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php
@@ -25,7 +25,13 @@ class CommentAttributesTest extends CommentTestBase {
    *
    * @var array
    */
-  protected static $modules = ['views', 'node', 'comment', 'rdf', 'user_hooks_test'];
+  protected static $modules = [
+    'views',
+    'node',
+    'comment',
+    'rdf',
+    'user_hooks_test',
+  ];

   /**
    * {@inheritdoc}

This needs re-rolling for 8.9

Backported to 9.0.x because this resolves a valid bug and there is little risk of disruption

Reroll for 8.9.x

Removing tag.

Reroll is good, just the $modules property visibility and setUp method return type have changed.

Committed e934b62 and pushed to 8.9.x. Thanks!

Backported to 8.9.x because this resolves a valid bug, has a passing test and there is little risk of disruption