Drupal 4.7.x

It's nothing big, it's just my personal webspace. But I've spend about two months worth of spare time making it, so i'd really like to hear what other drupal users think of it.

The main content of my site is my music and my php projects.

In the previous two months I've gone from really disliking coding for drupal, to not knowing why I bothered to code 1,8 content management systems on my own before trying Drupal seriously. At the end this resulted in the following:
- Theme that uses jsDOMenubar to generate dynamic menu from the drupal menu system.
- Filepublishing module: Upload files with ftp, publish them as a node with title and description, keep track of downloads.
- The filepublishing module allso feature a frontpage (as seen on my site) This is in the same module because I'm lazy..
- Cartoon aggregator module (this one might break some copyright regulations though :P ) : aggregates your favourite cartoons (can even bypass some deeplink protections, but I'm sure that's illegal).

So am I going to publish those modules and the theme?
I will publish them on my own website for sure, the code just needs a bit of beutification and to run for a couple of weeks.
But to publish here on Drupal.org? I don't know. I'm not sure If I'm up to the standard.

At last I'd like to say that I've really enjoyed the last two months of learning to work with Drupal, and I do

I'm getting an error when I have the taxonomy module enabled for all users except administrator (user #1). Here's the error:

* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '_node t INNER JOIN node n ON t.nid = n.nid INNER JOIN node_revis query: SELECT DISTINCT(n.nid), n.title, r.body, sticky, created FROM term INNER JOIN node_access na ON na.nid = n.nid _node t INNER JOIN node n ON t.nid = n.nid INNER JOIN node_revisions r ON r.vid = n.vid WHERE (na.grant_view >= 1 AND ((na.gid = 0 AND na.realm = 'all') OR (na.gid = 1 AND na.realm = 'term_access'))) AND t.tid IN (21) AND n.status = 1 ORDER BY sticky DESC, created DESC LIMIT 5 in c:\program files\apache group\apache\htdocs\drupal\includes\database.mysql.inc on line 108.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '_node t INNER JOIN node n ON t.nid = n.nid INNER JOIN node_revis query: SELECT DISTINCT(n.nid), n.title, r.body, sticky, created FROM term INNER JOIN node_access na ON na.nid = n.nid _node t INNER JOIN node n ON t.nid = n.nid INNER JOIN node_revisions r ON r.vid = n.vid WHERE (na.grant_view >= 1 AND ((na.gid = 0 AND na.realm = 'all') OR (na.gid = 1 AND na.realm = 'term_access'))) AND t.tid IN (19,18,17,13) AND n.status = 1 ORDER BY sticky DESC, created DESC LIMIT 10 in c:\program files\apache group\apache\htdocs\drupal\includes\database.mysql.inc on line 108.

I seem to have white space on a variety of my pages including my create content forms and my aggregator.

Example: http://dailyshowonline.com/aggregator

Anyone know how I can rid of this large gap?

-Scott

I'm nearing the end of porting my site www.whatdoesthatmean.com, a wiki install, to a drupal install, currently set up at test site www.whatdoesthatmean.ca.

There are only two content types at the drupal install - a flexinode I set up called an 'entry', and forum posts. At the moment there aren't any forum posts at the other site to worry about and import.

Please help me enhance a module that I am working on. Give some feedback on the chat module at http://webs7ven.com

When we bootstrap Drupal, we do this:

  // Initialize $_GET['q'] prior to loading modules and invoking hook_init().
  if (!empty($_GET['q'])) {
    $_GET['q'] = drupal_get_normal_path(trim($_GET['q'], '/'));
  }
  else {
    $_GET['q'] = drupal_get_normal_path(variable_get('site_frontpage', 'node'));
  }

Why do we put the results back into $_GET['q'] and not into a Drupal specific global variable? Or in a function that stores it statically? It seems to me that the above example loses on several counts:

1) we destroy the original $_GET['q'] (don't know whether this is useful in some cases)
2) we encourage people to access the path over and over again using $_GET['q'] which is lots of typing and not very descriptive, and locks us in to this one parameter.
3) makes it unintuitive to alter or change the value (you end up having to reassign $_GET['q']).

I'd suggest that instead we do something like this:

  global $drupal_path;

  // Initialize $_GET['q'] prior to loading modules and invoking hook_init().
  if (!empty($_GET['q'])) {
    $drupal_path = drupal_get_normal_path(trim($_GET['q'], '/'));
  }
  else {
    $drupal_path = drupal_get_normal_path(variable_get('site_frontpage', 'node'));
  }

Now, for the real-life situation that prompts me to ask the question. I've written an application that updates a table (made with theme_table) with AJAX in response to changes in taxonomy selectors. The AJAX PHP returns the entire table new, including the sorting and paging links. Since the path to the AJAX function is different than the path to the page that builds the original table, the sorting and paging gets broken after the first AJAX update because they both use $_GET['q'] in their code. So clearly, I'm going to have to reassign $_GET['q'] in the AJAX function to avoid this. It just seems really bad practice to me to do this. The stuff handed over from the server should be holy territory, never touched, immutable. It would seem much more intuitive to me to either reassign a global $drupal_path variable, or use a drupal_set_normal_path() function to do the same (and use drupal_get_normal_path instead of $_GET['q']).