I'm patching this module and i would like to fix some drupal coding standards to increase code legibility.

CommentFileSizeAuthor
#11 coding-standards.patch77.31 KBoriol_e9g
#6 coding-standards-2748923-6.patch44.11 KBoriol_e9g
#2 coding-standards-2748923.patch41.43 KBoriol_e9g
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oriol_e9g created an issue. See original summary.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Needs work » Needs review
FileSize
coding-standards-2748923.patch41.43 KB

Status: Needs review » Needs work

The last submitted patch, 2: coding-standards-2748923.patch, failed testing.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Needs work » Needs review

Testbot fails

joel_osc’s picture

joel_osc CreditAttribution: joel_osc at OpenPlus commented
Category: Task » Bug report
Priority: Minor » Normal

I would like to see this addressed as well... there are quite a few issues that make this code difficult to work with:

  • if statements improperly spaced: if($var){
  • use of 1 instead of TRUE
  • 4 space indent instead of 2
  • lowercase 'false' instead of uppercase 'FALSE'
  • }else{ all on the same line
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Assigned: Unassigned » oriol_e9g
FileSize
coding-standards-2748923-6.patch44.11 KB

Second strike. I think that we can commit this patch, although it's not perfect is much better.

Status: Needs review » Needs work

The last submitted patch, 6: coding-standards-2748923-6.patch, failed testing.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Needs work » Needs review
chetan-singhal’s picture

chetan-singhal CreditAttribution: chetan-singhal commented

I can't merge your patch but in my local I try to fix.

chetan-singhal’s picture

chetan-singhal CreditAttribution: chetan-singhal commented
Status: Needs review » Closed (fixed)
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
coding-standards.patch77.31 KB

Try with this patch, cleanly aply with the last dev version.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Closed (fixed) » Needs review
chetan-singhal’s picture

chetan-singhal CreditAttribution: chetan-singhal commented

@oriol_e9g
can you share patch with current dev version?

chetan-singhal’s picture

chetan-singhal CreditAttribution: chetan-singhal commented
Status: Needs review » Needs work
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented

@drupal_rocker The patch in #11 apply cleanly with 7.x-4.x-dev

chetan-singhal’s picture

chetan-singhal CreditAttribution: chetan-singhal commented
Status: Needs work » Fixed
chetan-singhal’s picture

chetan-singhal CreditAttribution: chetan-singhal commented
Status: Fixed » Closed (fixed)