Review and follow Coding Standards

@jrockowitz, I'll do that. Thank you for your help, support and advice.

Hello @jrockowitz,

I simplified my code, I use a hook_entity_type_build to add a form handler on Webform.
The route looks like this :

entity.webform.results_analysis:
  path: '/admin/structure/webform/manage/{webform}/results/analysis'
  defaults:
    _entity_form: webform.analysis
  requirements:
    _entity_access: webform.submission_view_any
    _custom_access: '\Drupal\webform\Access\WebformAccess:checkResultsAccess'

• The WebformAnalysisForm class now extends EntityForm.
• The WebformAnalysis class set but does not save webform.
• Webform is saved after the form is submitted with EntityForm::save.

Tell me what you think.

Sincerely,

I will review this

Updated the files with the help of phpcs and phpcbf, mainly:
- Added a new line at the end of the file webform_analysis.links.task.yml
- Added the missing member variable doc comments on several files
- Splitted the array up over multiple lines in file WebformAnalysisBlock.php

Overall, the affected files are:
- webform_analysis.links.task.yml
- WebformAnalysisBlock.php
- WebformAnalysis.php
- WebformAnalysisChart.php
- WebformAnalysisForm.php

Waiting for review.

I'll review this!

The code fixed all messages from PHPCS, however I found this message when I ran phpcs

FILE: /web/modules/contrib/webform_analysis/src/Plugin/Block/WebformAnalysisBlock.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
 61 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 62 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------

Time: 410ms; Memory: 10MB

Looking deeper into this warning, I realized that in constructor had this code:

$this->entityTypeManager = $entityTypeManager ? $entityTypeManager : \Drupal::entityTypeManager();
$this->formBuilder = $formBuilder ? $formBuilder : \Drupal::formBuilder();

So it's already being done the dependency injection, but for some reason has this conditional calling Drupal. I think it's better to leave it at that, so I'm moving it to RTBC!