Hello,

While working on refactoring the permissions of webform I came across this finding.

The method WebformSubmissionStorage::checkFieldDefinitionAccess() reads: 

    if (!$webform->access('submission_upates_any')) { // <---- The operation apparently looks like a misspelling.
       unset($definitions['token']);
     }

I believe per existing nomenclature there should be "submissin_update_any".

CommentFileSizeAuthor
#2 2996755-operation-misspelling-2.patch592 bytesbucefal91

Comments

bucefal91 created an issue. See original summary.

bucefal91’s picture

bucefal91 commented
Status: Active » Needs review
StatusFileSize
new 2996755-operation-misspelling-2.patch592 bytes

Here's the patch that renames operation. Let's see what tests say. I ran a subset of them locally and got green light.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Reviewed & tested by the community

Patch looks fine. Feel free to commit it.

  • bucefal91 committed 202d3c0 on 8.x-5.x 
    Issue #2996755 by bucefal91: Fixing a misspelling in operation.
bucefal91’s picture

bucefal91 commented
Status: Reviewed & tested by the community » Fixed

Committed :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.