Rewritten view output is not used for "Entity Select" field

Patch #143 from https://www.drupal.org/node/2174633 works (tested with Drupal 8.3.7) with Webform element Entity autocomplete. It does not appear to work with Entity radios, Entity select or Entity checkboxes.

The same patch does work with Content type's Entity reference fields using any of the widgets: Autocomplete, Select list, Autocomplete (Tags style), Check boxes/radio buttons

I applied patch number 174, it works fine with Drupal 8.4 but it does not work with Webform.

I tracked down to call to $options = self::translateOptions($options, $element); in src/Element/WebformEntityTrait.php to be the one that overrides the Entity select values. If someone is willing to put some time create a patch we'll appreciate (I'll see if I can do myself later).

Testing core I learned 8.5.x and 8.6.x should work with #2174633-206: View output is not used for entityreference options

D8.5 needs #2174633-190: View output is not used for entityreference options
D8.6 needs latest #2174633: View output is not used for entityreference options

I'm not sure why unwinding the options and translate those. And why the trait states

Translate the select options.

Attached patch is as below (commenting out loading translated nodes).

Please provide some manually test suggestions!

 /**
   * Translate the select options.
   *
   * @param array $options
   *   Untranslated options.
   * @param array $element
   *   An element.
   *
   * @return array
   *   Translated options.
   */
  protected static function translateOptions(array $options, array $element) {
    /** @var \Drupal\Core\Entity\EntityRepositoryInterface $entity_repository */
    $entity_repository = \Drupal::service('entity.repository');

    foreach ($options as $key => $value) {
      if (is_array($value)) {
        $options[$key] = self::translateOptions($value, $element);
      }
      else {
//        // Set the entity in the correct language for display.
//        $option = \Drupal::entityTypeManager()
//          ->getStorage($element['#target_type'])
//          ->load($key);
//        $option = $entity_repository->getTranslationFromContext($option);
//        $options[$key] = $option->label();
      }
    }
    return $options;
  }

Hmmm ... above was not a wise call. I was testing checkboxes.

Removing the lines in #8 results into a select containing HTML

Fixing the view result is IMHO too late as $options contains rendered view result which are then escaped.

After some debugging I did not found a direct solution. The options when coming from views should be typed as safe while user input must be cleaned somehow.

[edit] option is not allowed any other content but text https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option [/edit]

The override which wouldn't allow to display custom output comes from this line specifically

//        $options[$key] = $option->label();

We should probably assume that field output coming from view is already translated. Added a condition for checking wether the selection handler is coming from a view and generated a patch that just strip tags, which should take care of wrapping tags issue, although I think this can also be fixed through views configuration.

@Ericmaster The patch makes sense, but we should not call ::translateOptions when the entity select is 'views'.

The Views 'Entity Reference' display should be responsible for stripping HTML tags for the option text.

The below statement should be added to \Drupal\webform\Element\WebformEntityTrait::setOptions

//  If the selection handle is not views the translate entity reference options.
if ($element['#selection_handler'] != 'views')  {
   $options = self::translateOptions($options, $element);
}

The attached patch, hopefully, is the simplest solution. If someone can review and mark this ticket RTBC, I will commit it.

I committed the patch. Please download the latest dev release to review.

Just a note that even with the committed Webform patch, the Core patch referenced in #7 must still be applied.