No Attachment Link in Story Listings when using WebFM_Attachment [#137414]

Comment	File	Size	Author
#4	webfm.module.patch	1.1 KB	robmilne

Comment #1

robmilne CreditAttribution: robmilne commented 19 April 2007 at 17:08

Thanks for pointing that out - I wasn't aware of this behaviour. I'll take a look at this when I get my life back and can spend some time enhancing this module again.

Log in or register to post comments

Comment #2

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 19 April 2007 at 19:21

Great thanks. By the way - it is a wonderful module. We were previously using Fileshare and have completely replaced it on all of our sites with WebFM. We find it superior in every way.

Log in or register to post comments

Comment #3

robmilne CreditAttribution: robmilne commented 19 April 2007 at 19:48

Thanks for the appreciation. Too bad my manager at Web Networks didn't feel this way when I wrote the module. Too many non-billable hours of R&D.

Log in or register to post comments

Comment #4

robmilne CreditAttribution: robmilne commented 20 April 2007 at 02:58

File	Size
webfm.module.patch	1.1 KB

Piece of cake. Attached is the 5.1 patch. The 4.7 change is identical so I'll leave that for you to do manually (my working copy of 4.7 is out of synch).

Log in or register to post comments

Comment #5

robmilne CreditAttribution: robmilne commented 20 April 2007 at 03:00

Status:

Active

» Fixed

I owe the 4.7 branch an update to stay in synch with 5. This fix will be part of that release.

Log in or register to post comments

Comment #6

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 24 April 2007 at 15:41

Thanks for the quick response, but the patch doesn't seem to work correctly. First, it produces two Attachment tables (each with the attached files in them). Second, the link text on the teaser page that is supposed to read "# attachments" with a link to the full node rather reads "Array" and is not linked.

Or is there more that I need to do than simply incorporate the patch into webfm.module?

Log in or register to post comments

Comment #7

robmilne CreditAttribution: robmilne commented 24 April 2007 at 17:02

I only tested the 5.1 version for this change and it worked fine. The patch file is for 5.1 and cannot be applied automatically to 4.7! The fact that you are seeing crap displayed (and two tables?) would suggest to me that you applied this patch to your 4.7 module.

I'll test a 4.7 install tonight and generate a 4.7 patch.

Log in or register to post comments

Comment #8

robmilne CreditAttribution: robmilne commented 25 April 2007 at 01:10

OK, I generated a completely new release for 4.7 that fixes this issue (as well as other fixes that were implemented in 5.x-1.5)

Log in or register to post comments

Comment #9

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 7 May 2007 at 20:24

The update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.

Log in or register to post comments

Comment #10

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 7 May 2007 at 20:28

The update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.

Log in or register to post comments

Comment #11

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 7 May 2007 at 20:30

The update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.

Log in or register to post comments

Comment #12

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 7 May 2007 at 20:31

The update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.

Log in or register to post comments

Comment #13

jraper@groups.drupal.org CreditAttribution: jraper@groups.drupal.org commented 7 May 2007 at 20:42

Oops - sorry about all the submits. I was getting an "Internal Server Error" in response to my submissions and did not realize they were actually getting posted.