Problem/Motivation

We have a view with the "Input required" setting active, forcing users to select a filter before they can see results.
After updating to the beta7 release, the view is not shown any more, not even the exposed widgets.

This seems to be a regression from #3380691: Issue 2919092 breaks BC and causes issues for existing sites, where the appropriate condition || !empty($view->exposed_widgets) was removed (see the comparision between beta4 and beta7)

Proposed resolution

Bring back the condition.

CommentFileSizeAuthor
#11 no_results_fix-3399878-11.patch1.08 KBalieffring
#10 no_results_fix-3399878-10.patch2.83 KBdpacassi

Issue fork viewsreference-3399878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrshowerman created an issue. See original summary.

mrshowerman opened merge request !37

mrshowerman’s picture

mrshowerman
Location Munich
commented
Assigned: mrshowerman » Unassigned
Status: Active » Needs review
maxstarkenburg’s picture

maxstarkenburg
he/him
commented

This patch helps improves some regressions I'm seeing between beta6 and beta7, though I'm also seeing beta7 to remove view header/footer text (configured to "Display even if view has no result"), so I think the scope of the issue might be larger.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Related issues: +#3195386: Do not hide empty view if there are exposed filters (especially if filtering is required)
nagy.balint’s picture

nagy.balint commented

The patch works fine, thanks!

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Related issues: +#3426640: Cache metadata is not captured when no results

KurtTrowbridge made their first commit to this issue’s fork.

kurttrowbridge’s picture

kurttrowbridge
he/him
commented

As mentioned in #4, header and footer text still don't appear if there are no results, despite a header and/or footer set to display even when there aren't any. I updated the MR to include that as well.

dpacassi’s picture

dpacassi
Primary language English
Location Zürich, Switzerland
commented
StatusFileSize
new no_results_fix-3399878-10.patch2.83 KB

Adding a static file from the current stage of https://git.drupalcode.org/project/viewsreference/-/merge_requests/37 in case the MR gets updated/rerolled.

alieffring’s picture

alieffring commented
StatusFileSize
new no_results_fix-3399878-11.patch1.08 KB

Rerolling patch for beta 8 release

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Fixed

Merged! Thanks.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.