Passing null to parameter #1 ($data) of type string to unserialize() is deprecated

The solution worked, but the patch couldn't by applied with composer patches.
So here's is the newly created patch

This error also occurs in src/Plugin/Field/FieldType/ViewsReferenceItem.php, I've added a similar patch here for that issue.

Here's the combined patch

In my case $values['data'] is not even set in the array so I think using isset is more appropriate to ensure unserialize is not even called whne there is no data.

Opened a merge request.

@rodrigoaguilera thanks, that's the only real solution here, all patches are wrong. I'd vote for an !empty() instead of isset() to be even safer!

Confirming this issue!

I made that change.

The issue btw also leads to a warning:

Warning: Undefined array key "data" in Drupal\viewsreference\Plugin\Field\FieldType\ViewsReferenceItem->setValue()

I just noticed the warning in #13 as well.

I also noticed that https://git.drupalcode.org/project/viewsreference/-/merge_requests/23.patch breaks the views filtering when argument is set to feed a contextual filter.

Same here as #15. Path breaks filtering when using viewsreference with argument using paragraphs.

Yeah, there was a little bug in the merge request. The new commit should fix it.

Hello, any news about this issue?
Will be available a release soon or we should use the patch?
Thanks!

MR by @neclimdul LGTM!

(It also fixes the issue mentioned in #13).

current patch, for composer

Committed, thanks everyone! Had to reroll, so please help test the latest dev version!

The warning still exists on Drupal 10 with php 8.1 and viewsreference 2.0-beta6.
I attached a patch that fixes the issue in \Plugin\Field\FieldType\ViewsReferenceItem and Plugin\Field\FieldFormatter\ViewsReferenceFieldFormatter as they are using the 'data' array key without checking if it is set.
PS: the warning is generated only for the FieldType but I think adding the check for the FieldFormatter doesn't hurt :)

Howdy,

Patch from #26 applied cleanly on a Drupal 10.1 install with newly installed viewsreference 2.0-beta6.

After applying the patch, the error is gone.

When I tried to apply #26 to the latest 2x dev, composer just hangs or says it can't apply the patch.

I am attaching a small patch that resolves the error I am getting in ViewsReferenceFieldFormatter.php.

I tried #27 on drupal 10 and it worked fine for me as error gone. Thanks @drupalninja99.

#3 applies and removes the error on 9.5x / php 8.1.

#29 makes the views arguments not being respected anymore. Exactly what's described in #3405177: Contextual filters not respected when used in paragraph.

Everybody just needs to update to 2.0-beta7.

@seanB: Reading the comments here, should this be reopened or should someone please create a follow-up issue (I'd suggest so!)

I have the error on viewsreference:2.0.0-beta7 end php 8.2
Deprecated function: unserialize(): Passing null to parameter #1 ($data) of type string is deprecated in Drupal\viewsreference\Plugin\Field\FieldFormatter\ViewsReferenceFieldFormatter->viewElements() (line 98 of modules/contrib/viewsreference/src/Plugin/Field/FieldFormatter/ViewsReferenceFieldFormatter.php).

I've opened a new issue #3423648: unserialize() of NULL deprecation returns to ViewsReferenceFieldFormatter since there has been a re-emergence of a problem that this issue had resolved when it was closed.

#3380691: Issue 2919092 breaks BC and causes issues for existing sites, which was included in the beta7 release, allows null data to be passed to the unserialize() function again, without checking whether data might be null or not: unserialize($item->getValue()['data'], ['allowed_classes' => FALSE]) As I and others have found, null 'data' is possible in views reference fields (likely those saved a while ago when expectations for this field were looser), so we really need to bring back a sanity check here before calling unseralize().

My new ticket proposes a solution to re-fix this particular instance (line 98 of ViewsReferenceFieldFormatter.php)

(The 'data' field stores the "extra settings" configuration, which is also involved in #3402036: Configuration schema for "Enable extra settings" (title,pagination,...) incorrect. I wouldn't be surprised if this is related, but so far I've been unable to reconstruct what previous scenario allowed an empty 'data' field to begin with. It was likely in Drupal 9, which I no longer have an easy way to test.)

Without patch number 27, I get the warning mentioned in the issue.
But when applying it I don't get any "value" in the method "public function alterView(ViewExecutable $view, $value)" of my "
ViewsReferenceSetting custom setting.

My version is 2.0-beta7.

#36 confirm