Problem/Motivation

When rendering the video field class, the code is trying to retrieve a setting called "class" that might not always be set. When not set, a warning is thrown.

Proposed resolution

Check that the setting does exist.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Original report

Notice: Undefined index: class in video_embed_field_handle_vimeo() (Line 519 of video_embed_field/video_embed_field.handlers.inc).

CommentFileSizeAuthor
#4 2589857-4.patch877 bytesmichaellenahan
#2 2589857-2.patch560 bytesmichaellenahan

Issue fork video_embed_field-2589857

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

michaellenahan created an issue. See original summary.

michaellenahan’s picture

michaellenahan commented
StatusFileSize
new 2589857-2.patch560 bytes

Here's the patch.

michaellenahan’s picture

michaellenahan commented
Status: Active » Needs review
michaellenahan’s picture

michaellenahan commented
StatusFileSize
new 2589857-4.patch877 bytes

Oh, it's needed for video_embed_field_handle_youtube() as well.

Parker Sydnor Historic Site’s picture

Parker Sydnor Historic Site commented

Can you please let me know if this can be fixed with administrative controls in the Drupal website?

david_garcia’s picture

david_garcia commented
Status: Needs review » Reviewed & tested by the community
david_garcia’s picture

david_garcia commented
Issue summary: View changes
chris matthews’s picture

chris matthews commented
Parent issue: » #3019514: Plan for Video Embed Field 7.x-2.0 stable release

kunal_sahu made their first commit to this issue’s fork.

kunal_sahu’s picture

kunal_sahu commented

Hi @all Thanks you for all your patches. The patch 2589857-4.patch

</code> applied successfully.

<code>PS C:\xampp\htdocs\drupal\web\themes\custom\video_embed_field-2589857> git apply -v .\2589857-4.patch
Checking patch video_embed_field.handlers.inc...
Applied patch video_embed_field.handlers.inc cleanly.

Creating an MR for helping out maintainer. Thanks michaellenahan for the patch . Thanks

kunal_sahu opened merge request !13