Hey there, me again ;)

There is some issue about requesting a relationship to a user... When the relationship is setup to be automatically accepted, the message when adding a new relation says : "Are you sure you wish to send a new Follower request to User2?"

In this case, since the relation is automatically accepted, the message should say : "Are you sure you want to add the Follower relationship to User2" ?

I guess I will have to create a hacked version of this on my site, but still feels like a bug, more than a feature request... ?

Thanks,
Patchak

CommentFileSizeAuthor
#6 user_relationships_ui.forms_.inc_.453082.patch1.31 KBjaydub
#3 users_relationship-453082-2.patch1.06 KBMisterSpeed

Comments

alex.k’s picture

alex.k commented
Category: bug » feature
Priority: Normal » Minor

A patch implementing this would be welcome. Thanks.

MisterSpeed’s picture

MisterSpeed commented
Assigned: Unassigned » MisterSpeed
MisterSpeed’s picture

MisterSpeed commented
Status: Active » Fixed
StatusFileSize
new users_relationship-453082-2.patch1.06 KB

Please find the patch file for changing the text.

alex.k’s picture

alex.k commented

@63reasons thanks for looking into it. Sorry I meant a patch that does not alter the existing string, which seems to fit fine in the normal case of a relationship that is not automatically accepted :)

Also, if auto-accept is something that the user has set in their profile, it should not affect the string at all, since the requester does not know the details of requestee's account setup.

@patchak if you can alter the string on your site without a code change using translations or String Overrides, please just do so, rather than raise a support request.

patchak’s picture

patchak commented

Alex.k : thanks for the suggestion, but I think the module should eventually handle this kind of situation, since with twitter example, I'm sure a lot of users will expect to be able to create a simple "follower -> followee" relationship, and the text really should not be the same if you enforce that a certain type of relation should be automatically accepted anyway.. ?

jaydub’s picture

jaydub commented
Status: Fixed » Needs review
StatusFileSize
new user_relationships_ui.forms_.inc_.453082.patch1.31 KB

How about this patch?

alex.k’s picture

alex.k commented
Assigned: MisterSpeed » Unassigned
Status: Needs review » Fixed

Committed with a wording change, thank you. http://drupal.org/cvs?commit=208516

The change is to avoid writing "a %rel_name relationship", because if rel_name is e.g. associate, then you need to be using "an", not "a".

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.