Hi

Thanks for this great module. It could be helpful to add the 'this product is shippable' field, otherwise all imported products are non-shippable, even if shippable is set to default in Product content type settings.

So I added the following at line 45:

$targets['shippable'] = array(
'name' => t('UC: Shippable'),
'callback' => 'uc_feeds_feeds_set_target',
'description' => 'Ubercart:'. t('Shippable'),
);

(Sorry I don't know how to roll patches!)

Then in my CSV I have a column for shippable, set to '1' for each product that will be shippable.

Cheers

Comments

Durran’s picture

Durran CreditAttribution: Durran commented

How ironic, I found this very same issue tonight after loading 73000+ products through feeds/uc_feeds via csv file. I took for granted that the default value would be populated.
Would you think this issue should be termed as a bug report rather than a feature request/user interface, only because I would imagine the modules developer would want a default functionality that would mimick feeds original intent,... I think?
In my application, I sure wouldnt want to go through them one by one.
-Great module! I stuck with ubercart because I knew there would be sufficient addons such as this one. I "almost" have a complete store put together with just a few modules. Ubercart, feeds, and uc-feed mappers. Its cool watching the development happen :)

micheleannj’s picture

micheleannj CreditAttribution: micheleannj commented
Category: feature » bug
Status: Active » Needs review

subscribing -- I just confirmed that the store default settings don't apply to products imported via Feeds. (Nor do Power Tools defaults, but that's probably a separate issue.

Will check your patch and report back. Thanks!

Durran’s picture

Durran CreditAttribution: Durran commented

I applied above patch and reworked my csv, reimported.. and everything is working fine.

scarr’s picture

scarr CreditAttribution: scarr commented

Hi - thanks for writing this code. It looks like it should work perfectly, but in my case, it isn't. I've added the code, created a new column in my csv named "Shippable", mapped it to the UC: Shippable in the field mappers. Entered 1's all down the sheet, and did an upload - but all my products are still listed as not shippable. I'd love to troubleshoot if you can give me a heads-up as to how. I may be missing something obvious, but I don't think so. Thanks!

Robin Millette’s picture

Robin Millette CreditAttribution: Robin Millette commented
Assigned: Unassigned » Robin Millette

I'm working on fitting this patch with #1031700: Stock Levels with a new dev release out soon.

royr’s picture

royr CreditAttribution: royr commented
Title: Add shippable field » Add shippable field workaround

Hi,

I stated using this module and could not get it to work as well for the shippable field. Then I used feed tamper and set the default value to 1 and the shippable field was selected on my ubercart nodes. Hope this helps.

Vincent Rommelaars’s picture

Vincent Rommelaars CreditAttribution: Vincent Rommelaars commented
Component: User interface » Code
Category: bug » support

Hi,

sorry to re-open this issue, because the problem seemed to be solved.
I'm using the ubercart feeds plugin, but when I try to set the Shippable field and the Default Quantity field with feed tamperer default value 1, nothing happens (described as above in comment #6).
Any ideas on how to get this working?

I use:
ubercart-6.x-2.9
uc_feeds-6.x-1.x-dev
feeds-6.x-1.0-beta12
feeds_tamper-6.x-1.0-beta4

Thanks in advance.