Back to site button gone on several admin pages

apply patch to solved back button issue.

Tested and verified. Patch worked for me.

+++ b/core/modules/toolbar/css/toolbar.module.css
--- a/core/themes/classy/templates/layout/html.html.twig
+++ b/core/themes/classy/templates/layout/html.html.twig

+++ b/core/themes/classy/templates/layout/html.html.twig
@@ -29,6 +30,7 @@
+    is_admin_route ? 'is-admin-route',

This is currently only added to Classy. Since this impacts the functionality of all themes, I think we should add this to system module and all core themes (including Stable)

Slightly different solution, don't render the button when not in admin context, instead of trying to hide it through css. Could be there are some consequences that I don't see.

Failed tests as button won't be rendered any more when not on admin pages. Adjusted tests.

@JohanKleene, I believe the button is hidden in CSS because of caching purposes.

I created a new patch that is based on #8 and made the changes as suggested in #13.

reviewing this and also confirm that this issue is found in D10 too..

Verified #18 patch
Testing steps:

* created new instance of Drupal 9.5.x.
* Go to /admin/structure/taxonomy/manage/tags/overview.
* created one taxonomy.
* edit the taxonomy created in previous step.

After applying the patch still home or back to site is not visible.

Test result Fail.
Moving to need works.

Reference SS

After patch:

Good catch @aarti zikre,

The patch attached should fix this behaviour for Claro.

Patch #26 resolved issue.

Seems lika an unrelated test fail.

Here's a patch for 10.1.x and 10.0.x - some themes no longer exist :)

I've discussed this issue with @lauriii and @ckrina and the consensus is that the fix is a good one.

However I've realised that we need a change record in order to tell themers with custom and contrib themes to update their html.html.twig to include this new class.

Will create the change record.

Change record created, feel free to edit some of the wording as I found this one not particularly easy to write.

https://www.drupal.org/node/3313633

I've rewritten the CR https://www.drupal.org/node/3313633 to more about what we want people to do rather than the bug itself.

Yes, that looks a lot better! Thanks Alex.

Hmmm... just wondering out load here but is the solution a bit complex and external to the toolbar module (where the problem lies).

I think we could change toolbar_preprocess_html() to

function toolbar_preprocess_html(&$variables) {
  if (!\Drupal::currentUser()->hasPermission('access toolbar')) {
    return;
  }
  $variables['attributes']['class'][] = 'toolbar-tray-open';
  $variables['attributes']['class'][] = 'toolbar-horizontal';
  $variables['attributes']['class'][] = 'toolbar-fixed';
  $variables['attributes']['class'][] = 'toolbar-loading';
  if (\Drupal::service('router.admin_context')->isAdminRoute()) {
    $variables['attributes']['class'][] = 'toolbar-is-admin-route';
  }
}

And then we could remove that changes to the templates and the other preprocess function, update the CSS for the new (more consistent class name) and not need a CR... wouldn't this be a better change?

@alexpott,
Made changes in toolbar_preprocess_html(), as per comment #41,
Please review.

Thanks for the patch. Don’t forget to set the correct status on the issue 😉

Still needs some work:

And then we could remove that changes to the templates and the other preprocess function, update the CSS for the new (more consistent class name) and not need a CR... wouldn't this be a better change?

#41

Did a bit of triage here and this is no longer a novice level issue, mostly due to the work needed for #41.

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar has moved to contrib