XLIFF download /upload in local translator [#1998066]

Problem/Motivation

The local translator supports communication, workflows, metadata.

With high probability translators will want to download an xliff to work on it.
Still the server and/local translator will help them a lot in the job:
Dealing with transactions, versioning, job comments, assignment to the person, communication/feedback, statistics, ...
In future also preview and more.

So we want to use the local translator and add the xliff support. AND want to have comments in.

Later we want to export only what is unaccepted / came back for revision.

We have discussed about this topic in the Basel MeetUp in March 2016.

Comment	File	Size	Author
#16	file_management_local_1998066_16.patch	8.13 KB	cgalli
#16	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass
#16	file_management_local_1998066_16.interdiff.txt	2.71 KB	cgalli
#15	file_management_local_1998066_15.patch	8.14 KB	cgalli
#15	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass
#13	file_management_local_1998066_13.patch	7.96 KB	cgalli
#13	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass
#12	file_management_local_1998066_12.patch	4.77 KB	cgalli
#12	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass
#11	file_management_local_1998066_11.patch	4.79 KB	cgalli
#11	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass
#10	file_management_local_1998066_10.patch	4.66 KB	cgalli
#10	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass
#5	file_management_local_1998066_5.patch	2.55 KB	cgalli
#5	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass, 3 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker commented 20 May 2013 at 08:10

Title:

Xliff download /upload in local translator

» XLIFF download /upload in local translator

Comment #2

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker commented 22 October 2014 at 16:06

Issue summary:	View changes
Issue tags:		+XLIFF

Comment #3

johnchque

Spanish

Bolivia

CreditAttribution: johnchque at MD Systems GmbH commented 1 April 2016 at 15:03

Issue summary:

View changes

Comment #4

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker at MD Systems GmbH commented 6 April 2016 at 08:41

Version:

7.x-1.x-dev

» 8.x-1.x-dev

Oh, didn't find this, because it was still 7.x

Comment #5

cgalli CreditAttribution: cgalli as a volunteer commented 19 April 2016 at 12:41

File	Size
file_management_local_1998066_5.patch	2.55 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass, 3 fail

First proof of concept.

I chose the option to build an XLIFF file for every job created in the local translator. This simplifies the UI. But it also adds load to the process and may create unnecessary files.

Option 2 could be to have a button in the 'Manage file' pane to create the file when needed.

Comment #6

cgalli CreditAttribution: cgalli as a volunteer commented 19 April 2016 at 12:42

Status:

Active

» Needs review

Comment #7

19 April 2016 at 12:51

Status:

Needs review

» Needs work

The last submitted patch, 5: file_management_local_1998066_5.patch, failed testing.

Comment #8

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker at MD Systems GmbH commented 19 April 2016 at 12:53

We would prefer to generate the file in a page callback on request.

The UI thus still just needs to have a link to that.
What do you think?

Comment #9

cgalli CreditAttribution: cgalli as a volunteer commented 19 April 2016 at 12:57

Fair enough. Will work on that.

As far as reuse/duplication of code is concerned. I will continue in the same fashion until told otherwise. It seems clear though that some sort of reusable code bits could be useful...

Comment #10

cgalli CreditAttribution: cgalli as a volunteer commented 22 April 2016 at 16:10

Status:

Needs work

» Needs review

File	Size
file_management_local_1998066_10.patch	4.66 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass

Built the controller for export.

Got stuck when sending $data as file content

Please advise.

Comment #11

cgalli CreditAttribution: cgalli as a volunteer commented 23 April 2016 at 14:32

File	Size
file_management_local_1998066_11.patch	4.79 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass

File export working. Unfortunately, the redirect is included in the file text as well. Any idea how to prevent this?

Comment #12

cgalli CreditAttribution: cgalli as a volunteer commented 24 April 2016 at 15:30

File	Size
file_management_local_1998066_12.patch	4.77 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass

Export working
Import started. Data from the file will go into the task item fields, right?

Please advise

Comment #13

cgalli CreditAttribution: cgalli as a volunteer commented 7 May 2016 at 12:18

File	Size
file_management_local_1998066_13.patch	7.96 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.2 170 pass

Initial patch with export and import working.

Questions to be resolved:

- What status should an imported data item have. Checked?
- What happens to an imported task item? Should it be submitted automatically? Or does the user have to go through each item, saving and submitting individually?

Comment #14

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker at MD Systems GmbH commented 8 May 2016 at 20:33

If we want to support marking it as completed, it needs a checkbox on upload. By default it should not autoconfirm IMHO.

It's about local translator. The external tool can not support a real preview and people should use it before finalising. Also the external tool is likely to do less validation and that's why each item should be opened once and finalised, at least recommendedly.
Clearly, the local translator is not there yet, but it will improve into this direction step by step.