Term Reference Change contains code taken from this module and makes it available in a service to be used by other modules (including the term split module). We should depend on that API as well.

CommentFileSizeAuthor
#7 2930199-7.patch9.61 KBlegolasbo
#6 2930199-6.patch11.55 KBlegolasbo
#4 2930199-4.patch9.85 KBlegolasbo
depend-on-taxonomy-term-change.patch7.53 KBlegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo created an issue. See original summary.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services for Sijthoff Media commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, depend-on-taxonomy-term-change.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services for Sijthoff Media commented
Status: Needs work » Needs review
FileSize
2930199-4.patch9.85 KB

Update failing tests to inject the correct service.

Status: Needs review » Needs work

The last submitted patch, 4: 2930199-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services for Sijthoff Media commented
Status: Needs work » Needs review
FileSize
2930199-6.patch11.55 KB

Added @requires module term_reference_change annotation

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services for Sijthoff Media commented
FileSize
2930199-7.patch9.61 KB

Turns out that dependencies are only calculated every 12 hours based on the current dev branch. I've added the term_reference_change module as a dependency to term_merge.info.yml so it can be picked up by testbot after the new dev tarbal has been created.

This can then be (re)tested.

  • legolasbo committed 227dc86 on 8.x-1.x 
    Issue #2930199 by legolasbo: Depend on term_reference_change module to...
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services for Sijthoff Media commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.