I've installated lastest dev version and configured correctly (my config works fine with Simple FB connect), but if I go to login page /user/login/facebook it returns:

TypeError: Argument 7 passed to Drupal\social_auth_facebook\Plugin\Network\FacebookAuth::__construct() must be an instance of Drupal\Core\Logger\LoggerChannelFactory, instance of Drupal\redirect_404\Render\Redirect404LogSuppressor given, called in /var/www/teatro.it/modules/contrib/social_auth_facebook/src/Plugin/Network/FacebookAuth.php on line 59 in Drupal\social_auth_facebook\Plugin\Network\FacebookAuth->__construct() (line 81 of modules/contrib/social_auth_facebook/src/Plugin/Network/FacebookAuth.php).
CommentFileSizeAuthor
#3 fatal_error_in_route-2856632-3.patch1.17 KBZnak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sedax created an issue. See original summary.

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented

I think the issue happens because the constructor expects the LoggerChannelFactory object, and the logger object passed to it seems to be a customized one. Could you please test if changing LoggerChannelFactory to LoggerChannelFactoryInterface fixes the issue?

Znak’s picture

Znak CreditAttribution: Znak commented
Status: Active » Needs review
FileSize
fatal_error_in_route-2856632-3.patch1.17 KB
csedax90’s picture

csedax90 CreditAttribution: csedax90 commented
Status: Needs review » Fixed

patch #3 solves the problem

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented
Status: Fixed » Reviewed & tested by the community

An issue is usually considered fixed when the changes has been applied to the repository. Changing to RTBC

  • gvso committed 857228c on 8.x-1.x 
    Issue #2856632 by Znak: Use LoggerChannelFactoryInterface instead of...
gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented
Title: Fatal error in route /user/login/facebook » Use LoggerChannelFactoryInterface instead of LoggerChannelFactory
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I think this should be changed to just use \Psr\Log\LoggerInterface instead of the logger channel factory, unless there's a specific need to have the factory instead of the logger itself.

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented

I don't think there's a need to have the factory itself, but I guess loggers would implement ChannelFactoryInterface since it's the interface provided by core.

Is there a page where \Psr\Log\LoggerInterface is recommended or any core modules that use it?