Depending on whether or not role_delegation module has done its thing, and whether or not the field even exists on the form, there may be PHP notices.

CommentFileSizeAuthor
#3 single_user_role_PHP-warnings_2374919-2.patch2.02 KBgrndlvl
#1 single_user_role_PHP-warnings_2374919-1.patch2.23 KBdalin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Assigned: dalin » Unassigned
Status: Active » Needs review
FileSize
single_user_role_PHP-warnings_2374919-1.patch2.23 KB

Status: Needs review » Needs work

The last submitted patch, 1: single_user_role_PHP-warnings_2374919-1.patch, failed testing.

grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
Status: Needs work » Needs review
FileSize
single_user_role_PHP-warnings_2374919-2.patch2.02 KB

Let's try this one.

Basically the same patch just re-rolled against dev.

gbisht’s picture

gbisht CreditAttribution: gbisht at Acquia commented

Thanks dalin and grndlvl for raising the issue, but I went through all the scenarios and couldn't find any situation where PHP notices are coming. But still I made some changes based on your suggestions to make the code better.

gbisht’s picture

gbisht CreditAttribution: gbisht at Acquia commented
Status: Needs review » Closed (fixed)