For visibility and efficiency, error logs need to be exposed for both system administrators and for end users to more effectively debug.

Proposed solution:

1. Ensure PHP.ini spawns with error reporting and display errors
2. Update the vhost settings to write errors into the docroot (e.g. errors.txt or errors.log if its served)
3. Evaluate the output of Drush installation to capture (at least) provisioning errors (e.g. provision.txt/provision.log)

This is short term and we can evaluate better solutions moving forward.

CommentFileSizeAuthor
#27 2946732-show_logs-25.patch9.66 KBnerdstein
#25 2946732-show_logs-24.patch9.3 KBnerdstein
#24 2946732-show_logs-23.patch9.31 KBnerdstein
#22 2946732-show_logs-22.patch9.17 KBnerdstein
#21 2946732-show_logs-21.patch9.16 KBnerdstein
#20 2946732-show_logs-20.patch9.13 KBnerdstein
#19 2946732-show_logs-19.patch8.51 KBnerdstein
#18 2946732-show_logs-18.patch7.14 KBnerdstein
#17 2946732-show_logs-17.patch11.13 KBnerdstein
#16 2946732-show_logs-15.patch11.18 KBnerdstein
#15 2946732-show_logs-15.patch11.2 KBnerdstein
#13 2946732-show_logs-13.patch5.72 KBnerdstein
#12 2946732-show_logs-12.patch5.51 KBnerdstein
#11 2946732-show_logs-11.patch5.54 KBnerdstein
#10 2946732-show_logs-10.patch4.13 KBnerdstein
#9 2946732-show_logs-9.patch3.46 KBnerdstein
#8 2946732-show_logs-8.patch3.43 KBnerdstein
#7 2946732-show_logs-7.patch3.43 KBnerdstein
#6 2946732-show_logs-6.patch3.38 KBnerdstein
#5 2946732-show_logs-5.patch3.37 KBnerdstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nerdstein created an issue. See original summary.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Assigned: Unassigned » nerdstein
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Title: Enhance instance-specific logging » Tugboat: Enhance instance-specific logging

Bumping this up since we have launched the new TugboatQA backend. The primary need is around the installation and exposing visibility during the install, should things fail. This will help give people direct feedback on why a failure occurs when an instance is created.

SimplyTest is already writing the installation log output to a file after the install finishes. I think it would be much nicer to get output on the fly.

Something like this may make it possible via the API: https://api.tugboat.qa/api/previews/log/

Here is a very rough idea of how this can work.

1. A callback should be created that invokes the backend API call (this has the Tugboat config/key). This should retrieve the preview log and return an updated log.

2. We need to get the log periodically (10 seconds maybe?) through a front-end poling mechanism. This poling mechanism should only run during the install stop poling in all of the following conditions: a. an instance fails, b. an instance is successful.

3. A block should be created and be able to be placed on the progress page.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented

Big +1 to this feature. Over at #3083188: "The requested submission failed. 113%" you can see repeated reports of the dread "The requested submission failed. 113%" error. Upon further digging (by Adam, since us mere peon users cannot see this information atm), it turns out this is nearly always caused because the project in question is doing something funky, and could be resolved by the end users themselves. But not having that information, it leads us peon end users to the conclusion that simplytest.me (and/or Tugboat QA) itself is overly buggy and only works part of the time.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Active » Needs work
FileSize
2946732-show_logs-5.patch3.37 KB

This is a WIP but I want to push this up to see if it works.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-6.patch3.38 KB

Another test

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-7.patch3.43 KB

Another WIP

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-8.patch3.43 KB

Bug...

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-9.patch3.46 KB

More WIP for testing

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-10.patch4.13 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-11.patch5.54 KB

Changed rendering approach - WIP for testing

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-12.patch5.51 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-13.patch5.72 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented

This last patch is trying to process too much data and timing out. This was bundled with the progress updater AJAX to make use of that same refreshing code. It likely needs decoupled from it.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-15.patch11.2 KB

This is getting a rendered log now but needs a ton of styling cleanup. This is a first attempt.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-15.patch11.18 KB

That was a bad patch, reuploading

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-17.patch11.13 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-18.patch7.14 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-19.patch8.51 KB

This one tests well locally, pushing for testing

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-20.patch9.13 KB

Forgot to add the new CSS file

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-21.patch9.16 KB

stderr is not just for errors. It would be nice to highlight errors somehow. But, this cleans things up... one more time...

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-22.patch9.17 KB

Avoiding previously used drupal classes....

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Needs work » Needs review

The patch is up on https://bergste.in

Feedback welcomed

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-23.patch9.31 KB

This should address the red highlighting of errors

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-24.patch9.3 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Needs review » Needs work

The patch got the coloring of the log entries I wanted in place. However, after a failure, it continues to refresh indefinitely. It should stop and leave the log intact.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
FileSize
2946732-show_logs-25.patch9.66 KB
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Needs work » Reviewed & tested by the community

That looks good

  • nerdstein committed 6e1acb7 on 7.x-1.x 
    Issue #2946732 by nerdstein: Tugboat: Enhance instance-specific logging
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.