Ongoing issue to fix deprecations introduced in core 9.x

CommentFileSizeAuthor
#2 simplenews.deprecations.3154566-2.patch1.37 KBAdamPS
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AdamPS created an issue. See original summary.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Active » Needs review
FileSize
simplenews.deprecations.3154566-2.patch1.37 KB

Status: Needs review » Needs work

The last submitted patch, 2: simplenews.deprecations.3154566-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • AdamPS committed 5f676db on 3.x 
    Issue #3154566 by AdamPS: D10 compatibility
AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Needs work » Active
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

The assert contains thing breaks d9 tests and should be backported to 2.x. D8.8+ provides a shim for this.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS at AlbanyWeb commented
Status: Active » Patch (to be ported)

Yes it's a good idea, I am happy to backport D9 compatibility to 2.x. However I would like to limit it to that - i.e. no backporting to 1.x because it's not got to have 3 active branches.

Already there are now 2000 users of 2.x double the number from 3 months ago. We can encourage people to continue to migrate with #3124097: Deprecate 8.x-1.x and because they would like D9 support.

Are you happy with this approach?