The current code blindly assigns a menu-icon-* class to any menu item, whether or not a menu icon has been assigned. Also there is no common class assigned; in order to style multiple menu icons, pattern matching CSS selectors are required.

This patch modifies the behavior to only assign the class if an icon has been assigned, and also adds a common menu-icon class in that case.

CommentFileSizeAuthor
conditional_class.patch646 bytessmk-ka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smk-ka created an issue. See original summary.

hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio, Drupal Ukraine Community, FFW, Open Y for Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Looks good

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed

Done - http://cgit.drupalcode.org/simple_menu_icons/commit/?id=4483be9

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Fixed » Closed (fixed)