Problem/Motivation

shs currently loads the entire taxonomy tree of a vocabulary with $load_terms = TRUE, which isn't fun when a vocabulary is very large.

Also full terms are loaded via taxonomy_get_children() check if they have any children, whereas we could just do a SELECT 1 ... LIMIT(0, 1) query there.

Proposed resolution

Only use $load_terms = TRUE if i18n_taxonomy or entity_translation modules are installed.

Add a helper to check if a term has any children that doesn't load anything.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 shs-2673822.patch1.74 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Tag1 Consulting commented
Status: Active » Needs review
FileSize
shs-2673822.patch1.74 KB
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

  • stBorchert committed c60d526 on 7.x-1.x authored by catch 
    Issue #2673822 by catch: Improve performance of ajax callback
stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert at undpaul commented
Status: Reviewed & tested by the community » Fixed

Thanks for the work.
Seems, I really need to make a new release ... :/

  • stBorchert committed 92cd8a9 on 8.x-1.x 
    Issue #2673822 by catch: Improve performance of ajax callback.

  • stBorchert committed 26de4ce on 8.x-1.x 
    Revert "Issue #2673822 by catch: Improve performance of ajax callback...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.