Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
While working with parent issue, I have noticed .install file with hook_schema() implementation. This issue: https://www.drupal.org/node/2780205
I don't like this way of implementation. We should create a configuration entity type for shield page instead. What do you think about it?
I've prepared a simple patch, which provides necessary components for this. It would be great to commit it, and then continue other issues (i.e. add/edit/delete shield page).
Patch is attached (this is a template for configuration entity only).
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | screen.png | 50.38 KB | alan-ps |
| #4 | shield_pages-create_configuration_entity_type-2781637-4.patch | 7.66 KB | alan-ps |
Comments
Comment #2
alan-ps CreditAttribution: alan-ps commentedAny remarks are welcome :)
Comment #3
alan-ps CreditAttribution: alan-ps commentedThe patch need a little bit more work. I will post final variant a little bit late.
Comment #4
alan-ps CreditAttribution: alan-ps commentedThis is a patch (and appropriate screenshot which shows us what this patch do ("add shield page" feature will be added in the parent issue)).
It provides configuration entity type for shield pages. I don't add any management pages (except list (default)), because there are another issues for this. After this patch will be committed, we can start management page issues (i.e. parent issue (add), 2780217 (edit), 2780221 (delete)).
Comment #5
naveenvalechaAwesome work!
Looks ready to go.
Could you update the title and description of the followup tasks
#2780217: Add edit management page for shield page configurable.
#2780221: Add delete management page for shield page configurable.
Also add a follow issue for tests as well.
Comment #6
naveenvalechaComment #7
naveenvalechaCommitted and pushed to 8.x-1.x
Comment #9
naveenvalecha