I was writing my own tab module and trying to figure out why its settings weren't showing up. Finally, I narrowed it down to line 444 in theme_share_widget_tabs_settings():
<?php
$tab_settings = '

'.
>

Removing the style="display:none" makes the form display, as expected.

Comments

gribnif’s picture

gribnif commented

Let's try this again, since I can't edit my own post:

    $tab_settings = '<div class="tab-settings" style="display: none;">'.
greenskin’s picture

greenskin commented

I have the display set to none by default then when the tab row is clicked it shows the settings. I need to remove the hardcoded display none and have javascript hide it on page load that way the settings still show when javascript is disabled.

greenskin’s picture

greenskin commented
Status: Active » Fixed

Committed. By default tab settings are not hidden, but on page load if javascript is enabled it will hide them. Allows tab settings to be shown when javascript is disabled.

gribnif’s picture

gribnif commented
Status: Fixed » Needs review

While I like the fact that the titles are now clickable to show/hide, I don't think it's obvious that one is expected to do this. You might want to style it somewhat like a collapsible fieldset title, where there is an expand/collapse icon associated with the title, and it looks like a link.

greenskin’s picture

greenskin commented
Category: bug » feature
Status: Needs review » Fixed

Tab titles now look like links and the little triangle icon has been added.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.