Remove explicit references to implicitly referenced objects

Patch doesn't apply.

yep :)

Thanks for creating this issue (and not discussing it further in the other one). However, I largely disagree:

1. The behavior is not the same with or without &. Consider this hook body: $results = new ResultSet($query);. This is now possible, e.g., to override the results in case there are no hits – changing that would require passing an explicit copy of the variable when invoking the hook, and would be a BC break.
2. This is just the documentation of the hooks. The alter() method always passes by reference, so hook implementations are always allowed to have the parameter as a reference, or not, as they choose. But what is possible should be reflected in the documentation.

On the other hand, this already doesn’t work for the query alter hooks, for instance – as those are called with $this, which of course can’t be passed as a complete reference. (I tested it: assigning the reference to a new object is just silently ignored in this case.)
So, maybe removing it from those hook documentations does make sense. Patch attached, please tell me what you think.

I agree that being able to replace a passed in object as mentioned in 1. can be very useful in case there are no results, but it is also potentially destructive depending on when the hook is invoked, because it can potentially replace the object that has already been altered by another implementation. I'm aware that this is also the case with pretty much every other hook, so I guess that's sort-of-ok as is, but still is a design flaw in my opinion.

I think we discussed this in the events issue already as well: we can’t, and shouldn’t, keep people from doing something stupid. I think with every single alter hook in Drupal you can break things. Making them less powerful to make it harder to break things is not the way to go, at least in my opinion.

Anyways, committed this. Thanks again for the suggestion, and the feedback!