In the Index class (src/Entity/Index), we have the $properties property, it is however, never used to actually store something. It's only get's unset in the __sleep method.

We should remove the property and change the _sleep method.

CommentFileSizeAuthor
#6 Removed-unused-class-property-2642284-3.patch1.49 KBshabirahmad

Comments

borisson_ created an issue. See original summary.

shabirahmad’s picture

shabirahmad commented
Assigned: Unassigned » shabirahmad
anchal29’s picture

anchal29 commented
Status: Active » Needs review
StatusFileSize
new search_api-remove-properties-property-2642284-3.patch793 bytes

Here's a patch for it.

Status: Needs review » Needs work

The last submitted patch, 3: search_api-remove-properties-property-2642284-3.patch, failed testing.

The last submitted patch, 3: search_api-remove-properties-property-2642284-3.patch, failed testing.

shabirahmad’s picture

shabirahmad commented
Assigned: shabirahmad » Unassigned
Status: Needs work » Active
StatusFileSize
new Removed-unused-class-property-2642284-3.patch1.49 KB

Patch uploaded. Verified that the protected $properties is not used anywhere.

shabirahmad’s picture

shabirahmad commented
Status: Active » Needs review
chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Looks good!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Looks great, rtbc++.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Excellent, thanks a lot!
Committed.
(Gave anchal29 a side credit, too, since his patch is almost the same, just slightly out of date (apparently) and posted while the issue was already assigned to someone else.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.