Integrate Rules Scheduler with Advanced Queue [#2650398]

Rules Scheduler relies on the Drupal core queue to run its tasks, via cron.

For sites with many scheduled tasks, Advanced Queue - which can run in a daemonized process separate from cron - can be more appropriate.

Comment	File	Size	Author
#12	2650398-12-scheduler-advancedqueue.patch	5.98 KB	ZenDoodles
#12
#8	2650398-8-scheduler-advancedqueue.patch	6.46 KB	TR
#8	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 63 pass PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
#5	2650398-5-scheduler-advancedqueue.patch	6.48 KB	TR
#5	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply
#3	rules_scheduler-advancedqueue-2650398-3.patch	6.47 KB	pjcdawkins
#3	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply
#2	rules_scheduler-advancedqueue-2650398-2.patch	5.3 KB	pjcdawkins
#2	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 63 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 January 2016 at 17:12

pjcdawkins created an issue. See original summary.

Comment #2

pjcdawkins CreditAttribution: pjcdawkins at Centarro commented 14 January 2016 at 17:13

Status:

Active

» Needs review

File	Size
rules_scheduler-advancedqueue-2650398-2.patch	5.3 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 63 pass

First attempt. Patch co-authored with @kazanir.

Comment #3

pjcdawkins CreditAttribution: pjcdawkins at Platform.sh commented 19 June 2017 at 01:19

File	Size
rules_scheduler-advancedqueue-2650398-3.patch	6.47 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Adds rules_scheduler_delete_tasks() which can delete queued Advanced Queue tasks,

Comment #4

17 September 2018 at 03:05

Status:

Needs review

» Needs work

The last submitted patch, 3: rules_scheduler-advancedqueue-2650398-3.patch, failed testing. View results

File	Size
2650398-5-scheduler-advancedqueue.patch	6.48 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply

Comment #6

TR CreditAttribution: TR commented 17 September 2018 at 05:17

Issue tags:

+Needs tests

I haven't tested the patch, but I can tell you that "recommends[]" is not a thing - it needs to be removed.

Since we have tests for rules_scheduler using the default core queue, I think we should also have a parallel set of tests which use Advanced Queue instead. This can be done by adding Advanced Queue as a test_dependency[].

Comment #7

17 September 2018 at 05:21

Status:

Needs review

» Needs work

The last submitted patch, 5: 2650398-5-scheduler-advancedqueue.patch, failed testing. View results

Comment #8

TR CreditAttribution: TR commented 17 September 2018 at 05:26

Status:

Needs work

» Needs review

File	Size
2650398-8-scheduler-advancedqueue.patch	6.46 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 63 pass PHP 7.2 & MySQL 5.5, D7 Patch Failed to Apply

Sorry, got my patches mixed up. Here's the correct re-roll:

Comment #9

TR CreditAttribution: TR commented 7 November 2018 at 06:00

Also, what needs to be done to clean up tasks in Advanced Queue when Rules Scheduler is uninstalled? See #2882504: Rules scheduler tasks are left in the queue table for how it's being handled with the Drupal core queue...

Comment #10

TR CreditAttribution: TR commented 7 January 2019 at 09:07

Status:

Needs review

» Needs work

Needs to be re-rolled again against HEAD to fix the fuzz. But #6 and #9 need to be addressed too, so moving this to "Needs work".

If you would like to see this feature put into Rules, please work on the patch.

Comment #11

TR CreditAttribution: TR commented 21 March 2019 at 20:12

Version:	7.x-2.x-dev	» 8.x-3.x-dev
Status:	Needs work	» Postponed

There doesn't seem to be any interest in getting this in to D7 Rules. I am moving it to D8 and postponing it. The maintainers of Rules do not intend to work on this, so if this is something you want to see implemented then please supply a patch and address the outstanding questions.