HI Jacob and Rotating Banner Dev guys-

Let me know if this has been handled or if posted in the wrong place-

but in Google chrome- Rotating banner first appears really tiny in the header- then if you refresh the browser, it appears in full size. . .

here is the shrunken header issue in Chrome : http://strumviews.com/

I wonder if the CSS is not loading or something for that module. . . I have no idea. . .

However - on the other install I made it does not have this issue here : http://www.aimadvantage.com/

Same drupal platform, same host, same rotating banner install I am pretty sure-

Just must be a tiny error in the timing of the browser loading the css for Chrome in one instance- or something else???

Thanks for any ideas-
Aaron

CommentFileSizeAuthor
#5 0001-Defer-starting-the-slideshow-until-the-images-are-lo.patch14.78 KBjames.elliott
#4 0001-Restrict-slide-previews-to-fit-within-their-containe.patch14.18 KBjames.elliott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

james.elliott’s picture

james.elliott CreditAttribution: james.elliott commented

Hi Aaron.

This is a sticky issue that I've wrestled with a few times and obviously needs a better solution if it is still happening as you've shown.

The problem is that in Chrome, until the image is completely loaded its dimensions are 0 by 0. The javascript that is making the banner work isn't aware of this and starts operating using that 0 by 0 size. The reason it works when you reload the page is that Chrome has the image in cache and appropriately reports the size.

I think this may also require looking into the ordering of image loading as well to get a complete solution.

AimAdvantage’s picture

AimAdvantage CreditAttribution: AimAdvantage commented

Thanks James, I knew it had to do with the timing somehow of the CSS or dimension. . .

and of course as Google Chrome is gaining marketshare- it becomes more and more important-

Do you know if any patch will be issued for this idea?

I don't have a clue about js. . .

Thanks for an excellent module -

Aaron
http://www.aimadvantage.com

ksenzee’s picture

ksenzee
she/her
CreditAttribution: ksenzee commented
Status: Needs review » Active
Issue tags: -google, -bug, -Chrome, -refresh, -rotating_banner
james.elliott’s picture

james.elliott CreditAttribution: james.elliott commented
Status: Active » Needs review
FileSize
0001-Restrict-slide-previews-to-fit-within-their-containe.patch14.18 KB

I spent some time on this and have attached a patch. It makes quite a few changes to the styling of the rotating banners and how settings are passed to the jQuery Cycle plugin.

The version of jQuery Cycle that I tested against was 2.99 I'm not sure of backwards compatibility at this point.

james.elliott’s picture

james.elliott CreditAttribution: james.elliott commented
FileSize
0001-Defer-starting-the-slideshow-until-the-images-are-lo.patch14.78 KB

Blah, the last patch was less effective than desirable. New patch defers starting of the cycle until the images are loaded.