Problem/Motivation

After #2575703: Remove default fall-through from PlaceholderTrait::placeholderFormat() !placeholders are not considered as valid and tests are failing.

Proposed resolution

Find the !placeholder usages and replace it.

See CR https://www.drupal.org/node/2575819

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 fix_placeholders-2.patch1021 bytesgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new fix_placeholders-2.patch1021 bytes

Patch with the fix

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Needs work

The last submitted patch, 2: fix_placeholders-2.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.