The pipeline on 8.x-1.x is red since 2026-07-16, when core 11.4 and phpstan-drupal 2.1.0 both landed in CI.
- phpcs reports 10 LongLineDeclaration errors. Core enabled that sniff for all files in #3549730: Enable LongLineDeclaration , and this module runs phpcs with core's ruleset, see #2957751: Maintaining drupal coding standards.
- phpstan reports 8 errors from rules added in phpstan-drupal 2.1.0, plus a @phpstan-ignore that core 11.4 made unnecessary.
Run the phpcs and phpstan jobs on 8.x-1.x.
- Split the reported array declarations over several lines and drop the stale ignore.
- For phpstan, call getStorage() at the call site, use Yaml::decode() to read the config file, and drop the stale ignore. The baseline stays unchanged.
Review the MR.
None.
None.
None.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
herved commentedComment #4
herved commentedSide note: the phpcs job copies core's ruleset, see #2957751: Maintaining drupal coding standards.
That file uses include-patterns that only match paths inside core. In a contrib module they match nothing, so those sniffs are skipped without any warning.
This is what broke here. LongLineDeclaration was skipped until #3549730: Enable LongLineDeclaration removed its patterns in 11.4. MissingShort is still skipped today, and hides 27 errors that CI never sees.
The module could keep the defaults, and if needed ship its own phpcs.xml.dist instead. Then CI and local runs (via ddev-drupal-contrib) would report the same thing.
I kept the MR minimal, but I can address it here if that's ok or open a follow-up.
---
For phpstan I fixed the errors, so the baseline is unchanged.
This should be BC-safe: I searched contrib and nothing outside redirect extends RedirectDeleteMultipleForm or these test classes.
Comment #5
herved commentedComment #6
herved commentedComment #7
idebr commented