Implement automatic PHP library installation via composer [#2931935]

Comment	File	Size	Author
#14	2931935-14.patch	261 bytes	markdorison
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail
#12	2931935-12.patch	608 bytes	markdorison
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail
#10	2931935-8.patch	565 bytes	markdorison
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail
#8	2931935-7.patch	609 bytes	markdorison
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail
#6	2931935-3.patch	1.09 KB	markdorison
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail
#4	2931935-2.patch	12.07 KB	markdorison
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail
#2	2931935-1.patch	2.82 KB	markdorison
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail

Comment #1

20 December 2017 at 03:05

markdorison created an issue. See original summary.

Log in or register to post comments

File	Size
2931935-1.patch	2.82 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail

Comment #3

17 January 2018 at 20:46

Status:

Needs review

» Needs work

The last submitted patch, 2: 2931935-1.patch, failed testing. View results

Log in or register to post comments

Comment #4

markdorison

he/him

CreditAttribution: markdorison at Chromatic commented 17 January 2018 at 20:59

Status:

Needs work

» Needs review

File	Size
2931935-2.patch	12.07 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail

Added dev dependencies of for PHPCS usage and composer script commands to make ease their use. We should also document those script commands in the README.

Log in or register to post comments

Comment #5

17 January 2018 at 21:03

Status:

Needs review

» Needs work

The last submitted patch, 4: 2931935-2.patch, failed testing. View results

Log in or register to post comments

Comment #6

markdorison

he/him

CreditAttribution: markdorison at Chromatic commented 17 January 2018 at 22:30

Status:

Needs work

» Needs review

File	Size
2931935-3.patch	1.09 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail

I have not been able to find documentation on this but the other contrib examples I have found seem to omit composer.lock. Testing to see if a patch only with composer.json will pass testing.

Log in or register to post comments

Comment #7

17 January 2018 at 22:33

Status:

Needs review

» Needs work

The last submitted patch, 6: 2931935-3.patch, failed testing. View results

Log in or register to post comments

Comment #8

markdorison

he/him

CreditAttribution: markdorison at Chromatic commented 18 January 2018 at 15:02

Status:

Needs work

» Needs review

File	Size
2931935-7.patch	609 bytes
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail

Removed PHPCS dev dependencies to determine if they are interfering with testbot.

Log in or register to post comments

Comment #9

18 January 2018 at 15:09

Status:

Needs review

» Needs work

The last submitted patch, 8: 2931935-7.patch, failed testing. View results

Log in or register to post comments

Comment #10

markdorison

he/him

CreditAttribution: markdorison at Chromatic commented 18 January 2018 at 15:42

Status:

Needs work

» Needs review

File	Size
2931935-8.patch	565 bytes
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail

Testing with no dependency requirements.

Log in or register to post comments

Comment #11

18 January 2018 at 15:45

Status:

Needs review

» Needs work

The last submitted patch, 10: 2931935-8.patch, failed testing. View results

Log in or register to post comments

File	Size
2931935-12.patch	608 bytes
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail

File	Size
2931935-1.patch	2.82 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail
2931935-2.patch	12.07 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail
2931935-3.patch	1.09 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.6 1 pass, 16 fail
2931935-7.patch	609 bytes
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail
2931935-8.patch	565 bytes
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail

Comment #13

18 January 2018 at 19:34

Status:

Needs review

» Needs work

The last submitted patch, 12: 2931935-12.patch, failed testing. View results

Log in or register to post comments

File	Size
2931935-14.patch	261 bytes
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.6 1 pass, 16 fail

Comment #15

19 January 2018 at 20:46

Status:

Needs review

» Needs work

The last submitted patch, 14: 2931935-14.patch, failed testing. View results

Log in or register to post comments

Comment #17

markdorison

he/him

CreditAttribution: markdorison at Chromatic commented 19 January 2018 at 22:06

I had a hunch that the test runner failures had something to do with adding the composer.json file and not necessarily the contents of the file. I went ahead and made the commit despite the test failures on the patch. The tests then ran again on the 8.x-1.x branch and passed now that the file was in place. ¯\_(ツ)_/¯