Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There are 3 discount types for Recurly coupons:
- Fixed Amount
- Percentage
- Free Trial
Currently free trial coupons fail the "Check that the coupon is available in the specified currency" validation. However, free trial coupons should not be validated against this logic at all. Simple edit to the if statement solves it. Patch to follow...
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | interdiff-7-8.txt | 676 bytes | walangitan |
| #8 | free_trial_coupons-2816917-8.patch | 2.13 KB | walangitan |
| #7 | free_trial_coupons-2816917-7.patch | 1.67 KB | markdorison |
| #2 | free-trial-coupons-failing-validation-2816917-2.patch | 1.59 KB | dsbrianwebster |
Comments
Comment #2
dsbrianwebster CreditAttribution: dsbrianwebster as a volunteer commentedComment #3
bonked CreditAttribution: bonked commentedConfirming this fixes a major issue for those of us that have come to find out that unless you do manual checking, Recurly allows users to re-use trial periods over and over and over again. Had a single customer (thankfully only one) reuse our free 7 day trial for 26 weeks in a row.
The solution is to use Free Trial coupon codes - which we pre-populate for users that have never subscribed - this was broken by upgrading to 7.3.
Comment #5
markdorisonThank you for the patch! Committed to 7.x-3.x. This should be ported to the 8.x-1.x branch.
Comment #6
walangitan CreditAttribution: walangitan at Chromatic commentedComment #7
markdorisonComment #8
walangitan CreditAttribution: walangitan at Chromatic commented#7 applied cleanly and works well. Ran into a related bug that was incorrectly setting an error on the form during testing. This patch includes a resolution to that as well.
Comment #9
markdorisonComment #11
markdorison