I've found another little issue. The easiest way to reproduce is to enable the emails in (admin/config/protected_node ) and then create a new protected node with invalid emails. This should trigger a form error but instead only create a warning like this:

Warning: implode() [function.implode]: Invalid arguments passed in form_error() (line 1628 of /Applications/MAMP/htdocs/ac_architectes/includes/form.inc).

This is because the ($node, $form) function set the error on $arg['protected_node']… instead of $form['protected_node']…

patch following

CommentFileSizeAuthor
#1 form_error_validate-1583722-1.patch2.26 KBidflood

Comments

idflood’s picture

idflood commented
Status: Active » Needs review
StatusFileSize
new form_error_validate-1583722-1.patch2.26 KB
szt’s picture

szt commented
Status: Needs review » Reviewed & tested by the community

Works. Thanks.

zilverdistel’s picture

zilverdistel commented
Status: Reviewed & tested by the community » Fixed

Idflood,

I couldn't apply the patch, but manually made the changes. There was one more use of the $arg array, and I also removed a comment about that same variable.

Commit: http://drupalcode.org/project/protected_node.git/commit/4e7fac3.

Thanks!

Zilverdistel

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avinash_thombre’s picture

avinash_thombre commented
Issue summary: View changes

Install, enable and configure following mail systems and the warning will go off.
1. Default mail system - https://www.drupal.org/project/mailsystem
2. MIME mail system - https://www.drupal.org/project/mimemail
3. HTML maiil system - https://www.drupal.org/project/htmlmail