[2.x] Mortgage Calculators

Thank you for applying!

Before giving links helpful to understand how the review process works, what to expect from a review, and what to do to avoid a review takes more time than needed, I would like to thank all the reviewers for the work they do.
These applications are volunters-driven, which also means it is not possible to predict when an application will be marked fixed and the applicant will get the permission to opt projects into security advisory policy. While we aim to make an application as quick as possible, it is also important for us that more people review the project used for an application. In this way, we make sure applications do not miss some important points that should be instead reported.
Applications are not meant to be complete debugging sessions that eliminate every existing bug, though. I apologize if sometimes applications seem to go into too-detailed reviews.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issue, or does not correctly use the Drupal API
• The single review points are not ordered, not even by importance

The part about similar projects must be given in the project page. That section has been added, but it does not say anything about similar projects.

mortgage_calculators.info.yml

Projects used in these applications are supposed to be compatible only with supported Drupal releases. If the project needs to be be used with older Drupal releases, the code compatible with older Drupal releases should be in a different branch.
In most of the cases, the same code cannot be compatible with, for example, Drupal 9.x and Drupal 11.x. That means that splitting the project in two branches is required most of the times.

src/Form/CalculatorForm.php

  /**
   * {@inheritdoc}
   *
   * @param mixed[] $form
   *   The form array. Not narrowed: it is passed by reference, and the nested
   *   settings subform it carries is a plain array.
   * @param \Drupal\Core\Form\FormStateInterface $form_state
   *   The current form state.
   */

Documentation comments for inherited methods or methods defined in interfaces just need the {@inheritdoc} line. If the parameter descriptions do not say anything that is specific for that method, they can be removed.

mortgage_calculators.module

/**
 * @file
 * Procedural hook wrappers for Drupal 10.3 through 11.0.
 *
 * Drupal 11.1 and later discover the attribute-based implementations in
 * \Drupal\mortgage_calculators\Hook\MortgageCalculatorsHooks and skip every
 * function marked with #[LegacyHook], so no hook runs twice.
 *

The long description does not say anything that is specific for this module; it can be removed.
Also the short description does not say anything specific for this module, since which Drupal releases support procedural code and which Drupal releases support #[LegacyHook] is a detail about Drupal core. I would rather use the usual Hook implementations for the [module name] module. where [module name] is the module name reported in the .info.yml file.

1. FILE: src/Entity/Calculator.php

Projects that are compatible with Drupal 10 or higher versions should use attributes instead of annotations.

2. FILE: src/Plugin/Derivative/CalculatorBlockDeriver.php

  /**
   * The entity type manager.
   */
  protected EntityTypeManagerInterface $entityTypeManager;

  /**
   * Constructs the deriver.
   *
   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
   *   The entity type manager.
   */
  public function __construct(EntityTypeManagerInterface $entity_type_manager) {
    $this->entityTypeManager = $entity_type_manager;
  }

Modules which are compatible with Drupal 10 and higher versions are expected to use constructor property promotion.

I am changing priority as per Issue priorities.