[1.0.x] Simple Parallax JS

Thank you for applying!

Before giving links helpful to understand how the review process works, what to expect from a review, and what to do to avoid a review takes more time than needed, I would like to thank all the reviewers for the work they do.
These applications are volunters-driven, which also means it is not possible to predict when an application will be marked fixed and the applicant will get the permission to opt projects into security advisory policy. While we aim to make an application as quick as possible, it is also important for us that more people review the project used for an application. In this way, we make sure applications do not miss some important points that should be instead reported.
Applications are not meant to be complete debugging sessions that eliminate every existing bug, though. I apologize if sometimes applications seem to go into too-detailed reviews.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review. See also Policy on the use of AI when contributing to Drupal, which is valid when contributing to Drupal, either by committing code in a project, or by creating a merge request for an existing project.

The important notes are the following.

• For the purposes of this application, it is not necessary to create releases or pre-releases. It is better to make commits only on a branch, and possibly in the same branch used from the start.
• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

Reviewed 1.0.x (commit 3f7c696) on Drupal 10.3/11.

AUTOMATED REVIEW

phpcs (Drupal + DrupalPractice) is clean on the PHP/YAML. The remaining violations are in JS / build files:
- assets/js/simpleParallax.js: 6 errors — a lowercase "false" that should be "FALSE" (Drupal JS standard), and missing spaces around a ternary "?" (lines 17-19). This is your own behavior file, so please run it through the Drupal JS standards / prettier.
- vite.config.js: 3 errors (ternary spacing).
- dist/js/simpleParallax.js: flagged as minified.

Suggestion: add a phpcs.xml.dist that excludes build output (dist/) and tooling (vite.config.js), and fix assets/js so phpcs is green on the code you actually maintain.

MANUAL REVIEW — POSITIVES

- The single \Drupal::entityTypeManager() call is inside the static isApplicable() method, where service injection isn't available — this is the accepted core pattern, not an issue.
- No raw SQL and no unsafe output. core_version_requirement ^10.3 || ^11 || ^12, and no hardcoded version/project keys in the .info.yml.

SUGGESTIONS

- The release currently ships build tooling (package.json, package-lock.json, vite.config.js) and a compiled dist/. Consider whether these belong in the packaged release, or add a .gitattributes with export-ignore for the toolchain.
- The bundled simpleParallax.js third-party library should have its version and license documented (Drupal third-party asset policy).
- No automated tests yet — not required for coverage, but a small Kernel/FunctionalJavascript test would strengthen the module.

Good, focused module. Mainly needs the JS coding-standards cleanup and a decision on what to ship in the release.

1. FILE: README.md

The README file is missing the required sections - Requirements and Configuration.

2. FILE: src/Plugin/Field/FieldFormatter/SimpleParallaxFieldFormatter.php

 * @FieldFormatter(
 *   id = "simple_parallax_field_formatter",
 *   label = @Translation("Simple Parallax"),
 *   field_types = {
 *     "entity_reference",
 *     "image"
 *   }
 * )

Projects that are compatible with Drupal 10 or higher versions should use attributes instead of annotations.