Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Dec 2016 at 06:41 UTC
Updated:
11 May 2017 at 22:25 UTC
Jump to comment: Most recent
Comments
Comment #2
venu_gopal commentedComment #3
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxvenu_gopal2838317git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
venu_gopal commentedRemoved all errors from https://pareview.sh/. Please review it
Project URL : https://git.drupal.org/sandbox/venu_gopal/2838317.git
Comment #5
venu_gopal commentedComment #6
vivek.addweb commentedAutomated Review
Error from pareview.sh
Review of the 8.x-1.x branch (commit cf7576e):
Manual Review
README.txt doesn't provide detailed information & third party file details.
t() function is not used in theme.
This review uses the Project Application Review Template.
Comment #7
venu_gopal commentedHi @vivek.addweb
Thanks for reviewing my theme
Removed errors, please check and let me know
Thanks for review
Comment #8
venu_gopal commentedComment #9
deepali_agarwal commentedAutomated Review
Review of the 8.x-1.x branch (commit e2ca412):
FILE: /root/repos/pareviewsh/pareview_temp/vgtheme.theme
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 19 spaces but found 1 space
Manual Review
Found some points that should be taken care of:
Comment #10
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.