Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Dec 2015 at 16:34 UTC
Updated:
8 Sep 2018 at 21:29 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
kallehauge commentedAutomated Review
No issues found.
Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Observations: the README does not include a "requirements section". This is needed because it depends on a module outside of Drupal Core (Feeds & Ultimate Cron).
Code long/complex enough for review
No: Does not follows the guidelines for project length and complexity.
Observations: The suggested amount of functions and lines of code is less than the suggested amounts in the guidelines.
Secure code:
Yes: Meets the security requirements.
Coding style & Drupal API usage:
Does a good job using drupal_static(), correctly using placeholders in t() functions and uses proper argument substitution in db queries.
Comment #4
sinn commentedDuplicate of https://www.drupal.org/node/2254221
Comment #5
avpaderno